- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Patch Failed to Apply - π¬π·Greece bserem
#25 works fine here too. I'll update the status so that this might get some more action.
- πΊπΈUnited States hongpong Philadelphia
Ok adding pathauto as a new requirement since it doesn't work otherwise. Re rolling from #25 and updated requirements and the new Base URL field to have more informative description.
-
hongpong β
committed 5a5ed109 on 8.x-3.x
Import permalink as URL paths #2904545
-
hongpong β
committed 5a5ed109 on 8.x-3.x
- πΊπΈUnited States hongpong Philadelphia
Thank you damienmckenna, splash112, caspervoogt, phjou, ivrh, bserem, tabestan, john_b, apmsooner! Well done.
- πΊπΈUnited States hongpong Philadelphia
- π©π°Denmark ressa Copenhagen
Thanks everyone, this is a great feature to get into the module!
@hongpong: I think you can add credit later on ... Checking the users with missing credit in this issue, I think everyone deserves recognition...
If the below is not correct, perhaps the documentation could get an update, or an issue created, to fix it?
- Use the checkboxes and Commit message field to generate a suggested commit message for the issue. While issue credits may be modified after the commit, commit message mentions can only be changed by amending the commit message (for git commits that are not yet pushed) or with reverting the commit and making the correction in a new commit (for commits that are pushed). Drupal.org prohibits the use of git force push β to release branches, so making commit message changes that way is not possible.
From https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... β
- πΊπΈUnited States hongpong Philadelphia
@ressa Alright how about let's 1) update the documentation README regarding the base url field, and 2) move the permalink code into a new function within the same file? That function is already huge and I think would be better divided up anyway, to make development easier, fewer merge conflicts and so on.
Then everyone can be credited on that commit and hopefully it will be added to the Drupal contribution credits brain. (as far as I can understand what they say, it is not possible to attach credit to previous commits because 'force' push is not possible.) Again I am sorry about the 'credit' issue particularly since this took a lot of work to sort out!
Regarding a new release alpha7 I would hope to get both the pluggable extensions, and the Drupal 11 fix, onto the codebase before a release. However obviously many things are broken with alpha6 so, if we cannot get those sorted within a few days, then yes I think it would be fine to tag a new release within the next week regardless.
- π©π°Denmark ressa Copenhagen
Actually, as I read the Granting credit β text, it's possible to give credit by simply checking the names under "Credit & committing", and saving the issue, also after changing status to Fixed. You could try it?
As I understand it, the Git commit crediting option is for the commit message in Gitlab, not the actual crediting ...
I think your plan sounds great. Getting pluggable extensions and Drupal 11 ready first if possible, before a new release makes a lot of sense -- depending on if it's too demanding, or not.
- πΊπΈUnited States hongpong Philadelphia
attempting to update credits, thanks ressa!
- π©π°Denmark ressa Copenhagen
You're welcome! As we both agree, the Granting credit to issue contributors β documentation page was a bit ambiguous, I had to study it closely to understand it ...
So I have updated it, attempting to make it clearer. What do you think about it now @hongpong?
- πΊπΈUnited States hongpong Philadelphia
@ressa yeah that is way easier to understand cheers!
- π©π°Denmark ressa Copenhagen
Thanks for checking @hongpong, that's great!
- Merge request !26Issue #2904545 by damienmckenna, hongpong, splash112, caspervoogt, phjou,... β (Merged) created by hongpong
-
hongpong β
committed 5a31c470 on 8.x-3.x
Issue #2904545 by damienmckenna, hongpong, splash112, caspervoogt, phjou...
-
hongpong β
committed 5a31c470 on 8.x-3.x
- πΊπΈUnited States hongpong Philadelphia
The readme is updated significantly (including all contributors to date added), the pathauto / path alias function is extracted to a new function processUrlPathAliases. Thanks everyone.
Automatically closed - issue fixed for 2 weeks with no activity.