Contrib.social

Wrong render of HTML from label when field is shared across languages in error message

Open on Drupal.org →
Created on 2 August 2017, almost 8 years ago
Updated 6 September 2024, 10 months ago

When setting up an entity bundle to be translatable, people have a choice of making each field translatable or not.

When a node gets an error for example because you try to save a node with required fields.
The label name is used in the error message as "@name is required".

Because content translation is putting (all languages) after the label this is also appearing in the error message.
So the error will be: "Field 1 (all languages) field is required." But the current message is "Field 1 (all languages) field is required."

Problem: HTML is not rendered well in the error message.

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Content translation  →

Last updated 4 days ago

No maintainer
Created by

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment 10 months ago →
    🇬🇧United Kingdom jonathan1055

    Fixed issue summary to correctly show the < and >

  • Comment 10 months ago →
    🇮🇳India KumudB Ahmedabad

    It appears that this issue has been resolved in the latest version of Drupal 11. I have tested the scenario and verified that the error message no longer includes the "(all languages)" suffix.

    I have attached a screenshot for reference. Given that the problem is no longer present, I believe we can close this issue.

    Thank you!

  • Comment 7 months ago →
    🇬🇧United Kingdom pobster

    Not everyone is on 11.x yet... This is rerolled for 10.3.x.

  • Comment 5 months ago →
    🇳🇿New Zealand quietone

    Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

    This is changing a user facing error message so will need before and after screenshots. They should be available to reviewers/committers from the Issue Summary.

    This also needs an issue summary update, add the standard issue template → and complete the 'Problem/Motivation', 'Steps to reproduce', and 'Proposed resolution' sections. Leave the other sections empty for use by other contributors.

  • Comment 5 months ago →
    🇬🇧United Kingdom pobster

    https://www.drupal.org/project/drupal/issues/2899338#comment-15774058 🐛 Wrong render of HTML from label when field is shared across languages in error message Needs work

    It appears that this issue has been resolved in the latest version of Drupal 11.

  • Status changed to Closed: won't fix 10 days ago
  • Comment 10 days ago →
    🇳🇿New Zealand quietone

    @pobster, thanks for repeating that this is fixed in D11. I couldn't find the issue where this was fixed but it wasn't backported to D10.

    Thanks everyone for working on this issue. The current error message should render the HTML correctly, However, this

    I agree that the current string is somewhat misleading, and the suggested change would improve it. However, Drupal 10 is in maintenance mode and this issue doesn't meet the criteria for an allowed change in a maintenance minor → ,

    Therefor, I am closing this issue as won't fix.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024