- π―π΅Japan kazuko.murata
kazuko.murata β made their first commit to this issueβs fork.
- Merge request !6803Issue #2887988: Translation of file count is incorrect β (Closed) created by kazuko.murata
- Status changed to Needs review
9 months ago 2:53am 28 February 2024 - π―π΅Japan kazuko.murata
Hello.
I agree with the comment in #16. I always modify the configuration of the 'count' field in Views settings after installing Drupal and use it.
I propose the fix through https://git.drupalcode.org/project/drupal/-/merge_requests/6803
I would appreciate it if someone could review it. Thank you.
- Status changed to Needs work
9 months ago 2:22pm 28 February 2024 - πΊπΈUnited States smustgrave
Leaving needs step to reproduce as those should be in the issue summary.
But noticed issue summary isn't using standard issue template with the correct sections so tagging for that.
Thanks.
- Status changed to Needs review
9 months ago 5:10am 5 March 2024 - π―π΅Japan kazuko.murata
I've revised the summary. If you come across any typos or unclear descriptions, I'd be grateful if you could make the necessary corrections. Thanks to anyone who takes the time to review it.
- Status changed to Needs work
9 months ago 3:52pm 5 March 2024 - πΊπΈUnited States smustgrave
Thanks, leaving the summary tag though for the missing sections. I added them to hopefully help.
Also ran the test-only job https://git.drupalcode.org/issue/drupal-2887988/-/jobs/920335 and it did fail to show coverage.
Issue summary mentions D8 but assume this is a D10 problem too.
Looks close.
- π―π΅Japan kazuko.murata
@smustgrave Thank you for your review.
I understand that the job has failed.
This modification is a site configuration change, so
ConfigTranslationUiTest.php
andviews.view.files.yml
must be modified simultaneously.I think it's natural for the test to fail as a result of Reverting non test changes.
What would be the best course of action? I would appreciate any guidance.
- Status changed to Needs review
4 months ago 4:28am 5 August 2024 - Status changed to Needs work
4 months ago 12:51pm 5 August 2024 - πΊπΈUnited States smustgrave
Test only job on a bug should fail thatβs fine.
But issue summary is still incomplete
- Status changed to Needs review
4 months ago 1:58am 6 August 2024 - π―π΅Japan kazuko.murata
The summary has been updated to state that it also occurs in Drupal core 11.0.0.
I would be happy if anyone could review it again. - Status changed to Needs work
4 months ago 1:32pm 6 August 2024 - πΊπΈUnited States smustgrave
Summary still says proposed solution is TBD
- Status changed to Needs review
4 months ago 7:25am 8 August 2024 - Status changed to RTBC
3 months ago 4:16pm 8 August 2024 - Status changed to Fixed
3 months ago 3:57am 18 August 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked back to 10.4.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.