Coding Standard issues

Created on 19 June 2017, over 7 years ago
Updated 21 August 2024, 4 months ago

There are some coding standard issues in module.

šŸ› Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India jayesh_makwana

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡®šŸ‡³India sidharth_soman Bangalore

    Patch #5 does not apply.

    C:\xampp\htdocs\backendassignment\web\modules\contrib\conversational_forms-2887255>git apply -v coding_standard_issue_fixed-2887255-5.patch
    Checking patch conversational_forms.info...
    error: conversational_forms.info: No such file or directory
    Checking patch conversational_forms.module...
    warning: conversational_forms.module has type 100644, expected 100755
    error: while searching for:
    <?php
    
    /**
     * @TODO
     *  1. JS Field Validation
     *  2. Conditional fields --x
     *  3. Configuration
    
    error: patch failed: conversational_forms.module:1
    error: conversational_forms.module: patch does not apply
    Checking patch css/conversational_forms.css...
    error: css/conversational_forms.css: No such file or directory
    Checking patch example/fapi.example.inc...
    error: example/fapi.example.inc: No such file or directory
    Checking patch includes/conversational_forms.admin.inc...
    error: includes/conversational_forms.admin.inc: No such file or directory
    Checking patch includes/webform.inc...
    error: includes/webform.inc: No such file or directory
    

    I am working on this now.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • šŸ‡®šŸ‡³India sidharth_soman Bangalore

    Please review this patch.

  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @sidharth_soman,

    I applied patch#7 and encountered an error.

    āžœ  conversational_forms git:(7.x-1.x) curl https://www.drupal.org/files/issues/2023-01-30/2887255-7.patch | git apply -v
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 18654  100 18654    0     0  69852      0 --:--:-- --:--:-- --:--:-- 69865
    <stdin>:33: trailing whitespace.
     1. Copy/upload the conversational_forms module to the
    Checking patch README.md...
    error: README.md: No such file or directory
    Checking patch conversational_forms.info.yml...
    error: conversational_forms.info.yml: No such file or directory
    Checking patch conversational_forms.links.menu.yml...
    error: conversational_forms.links.menu.yml: No such file or directory
    Checking patch conversational_forms.module...
    warning: conversational_forms.module has type 100755, expected 100644
    error: while searching for:
    <?php
    
    use Drupal\Component\Utility\Html;
    use Drupal\Core\Form\FormStateInterface;
    use Drupal\Core\Render\Element;
    
    error: patch failed: conversational_forms.module:1
    error: conversational_forms.module: patch does not apply
    Checking patch conversational_forms.webform.inc...
    error: conversational_forms.webform.inc: No such file or directory
    Checking patch src/ConversationalFormsBase.php...
    error: src/ConversationalFormsBase.php: No such file or directory
    Checking patch src/Form/ConversationalFormsConfiguration.php...
    error: src/Form/ConversationalFormsConfiguration.php: No such file or directory
    Checking patch src/Form/Example.php...
    error: src/Form/Example.php: No such file or directory
    āžœ  conversational_forms git:(7.x-1.x)

    Thank you.

Production build 0.71.5 2024