-
svendecabooter →
committed be458304 on 2.0.x authored by
dipesh_goswami →
Issue #2886164 by dipesh_goswami, jayesh_makwana, nitin_lama,...
-
svendecabooter →
committed be458304 on 2.0.x authored by
dipesh_goswami →
- Status changed to Needs work
almost 2 years ago 5:44am 12 May 2023 - 🇬🇧United Kingdom steven jones
@svendecabooter the changes in be458304 have introduced a fatal TypeError :)
Specifically:
TypeError: Cannot assign Drupal\Core\Config\ImmutableConfig to property Drupal\video_embed_html5\Plugin\video_embed_field\Provider\Html5::$config of type Drupal\Core\Config\ConfigFactoryInterface in Drupal\video_embed_html5\Plugin\video_embed_field\Provider\Html5->__construct() (line 109 of modules/contrib/video_embed_html5/src/Plugin/video_embed_field/Provider/Html5.php).
This is because the property
Drupal\video_embed_html5\Plugin\video_embed_field\Provider\Html5::$confighas a type ofDrupal\Core\Config\ConfigFactoryInterfacewhen it should have a type ofDrupal\Core\Config\ImmutableConfig. - First commit to issue fork.
- @sakthi_dev opened merge request.
- Status changed to Needs review
almost 2 years ago 6:06am 12 May 2023 - 🇮🇳India sakthi_dev
Please review. Committed the code based on comment #19.
- Status changed to Needs work
almost 2 years ago 6:17am 12 May 2023 - 🇬🇧United Kingdom steven jones
@sakthi_dev no, that code is wrong, but in a different way!
Either we need a new MR based off of the currently committed code to 2.0.x or we need to wait for @svendecabooter to commit a fix directly.
-
svendecabooter →
committed 2da3d63a on 2.0.x
Issue #2886164: PHP TypeError followup
-
svendecabooter →
committed 2da3d63a on 2.0.x
- Status changed to Fixed
almost 2 years ago 7:00am 12 May 2023 - 🇧🇪Belgium svendecabooter Gent
Oops sorry - did not test enough before committing.
This will be fixed in a 2.0.1 release. Automatically closed - issue fixed for 2 weeks with no activity.