- Status changed to Needs work
8 months ago 7:06am 21 August 2024 - šµšPhilippines cleavinjosh
Hi @Deepthi kumari,
I applied patch #3, it was applied smoothly and fixed most of the phpcs issues.
There are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:ā bootstrap_colors git:(8.x-1.x) curl https://www.drupal.org/files/issues/2020-03-24/bootstrap_colors-codingstandard-2885384-3.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 52727 100 52727 0 0 118k 0 --:--:-- --:--:-- --:--:-- 118k patching file assets/bootstrap_colorpicker/css/bootstrap-colorpicker.css patching file assets/tinycolor/tinycolor.js patching file bootstrap_colors.module patching file css/bootstrap_colors.css patching file js/bootstrap_colors.js patching file src/Controller/BootstrapColorsController.php patching file src/Form/ColorForm.php ā bootstrap_colors git:(8.x-1.x) ā .. ā contrib phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js bootstrap_colors FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/bootstrap_colors.info.yml --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------- 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" --------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/js/bootstrap_colors.js ------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------ 132 | ERROR | [x] Opening brace should be on the same line as the declaration 158 | ERROR | [x] Opening brace should be on the same line as the declaration 168 | ERROR | [x] Opening brace should be on the same line as the declaration ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/assets/tinycolor/tinycolor.js ------------------------------------------------------------------------------------------------------------------- FOUND 21 ERRORS AFFECTING 20 LINES ------------------------------------------------------------------------------------------------------------------- 164 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 185 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 207 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 229 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 259 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 321 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 322 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 331 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 338 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 345 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 375 | ERROR | [x] Expected 1 space before opening brace; found 0 555 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 755 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 786 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 807 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1104 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1107 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 1162 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1187 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/assets/bootstrap_colorpicker/js/bootstrap-colorpicker.min.js -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/assets/bootstrap_colorpicker/js/bootstrap-colorpicker.js ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 144 ERRORS AFFECTING 136 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 22 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 26 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 194 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 198 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 206 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 208 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 213 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 217 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 237 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 245 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 246 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 257 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 259 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 263 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 266 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 269 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 272 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 275 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 299 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 306 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 331 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 338 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 340 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 348 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 362 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 378 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 400 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 402 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 410 | ERROR | [x] Case breaking statements must be followed by a single blank line 416 | ERROR | [x] Case breaking statements must be followed by a single blank line 422 | ERROR | [x] Case breaking statements must be followed by a single blank line 428 | ERROR | [x] Case breaking statements must be followed by a single blank line 433 | ERROR | [x] Case breaking statements must be followed by a single blank line 437 | ERROR | [x] Case breaking statements must be followed by a single blank line 451 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 462 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 473 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 484 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 495 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 506 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 517 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 528 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 537 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 541 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 544 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 547 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 548 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 549 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 550 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 552 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 564 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 570 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 585 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 591 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 599 | ERROR | [ ] String concat is not required here; use a single string instead 602 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 603 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 606 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 608 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 610 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 610 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 612 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 614 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 615 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 615 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 619 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 621 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 624 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 625 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 627 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 645 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 651 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 656 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 658 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 669 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 676 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 681 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 688 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 694 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 694 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 701 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 701 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 710 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 719 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 722 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 725 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 733 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 734 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 735 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 748 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 750 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 761 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 771 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 783 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 788 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 790 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 802 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 806 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 811 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 829 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 831 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 845 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 847 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 847 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 847 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 857 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 857 | ERROR | [x] Opening brace must be the last content on the line 859 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 866 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 874 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 880 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 881 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 883 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 885 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 887 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 889 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 891 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 897 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 899 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 901 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 903 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 909 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 911 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 913 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 918 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 939 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 958 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 960 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 992 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1006 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 1012 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1014 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 1023 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1025 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 1028 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 1033 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 1038 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 1044 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1047 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1047 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 1063 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 1067 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 143 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/src/Form/ColorForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/bootstrap_colors/src/Controller/BootstrapColorsController.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBuilderInterface. ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- Time: 467ms; Memory: 24MB ā contribThank you.