- Status changed to Needs work
almost 2 years ago 9:54pm 14 February 2023 - 🇺🇸United States smustgrave
YES! When I was starting in Drupal knowing this would of been nice.
I agree with both you that FieldItemListInterface seems like a good place though.
The only documentation on getValue() on https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21TypedData... is that it "Gets the data value."
While technically I guess its accurate, the implementation here adds logic that could do with an explanation. For example, it introduces logic to ignore Computed properties. Why? It would be helpful to put some of that here so people who stumble across have an idea of what's going on.
We ran into a problem recently with a custom field type and the interaction with Inline Entity Form.
It just seems that Computed properties are part of the "value" of a FieldItem, and some documentation would have helped us make a decision about which direction to go.
Needs work
10.1 ✨
Primarily changes documentation, not code. For Drupal core issues, select the Documentation component instead of using this tag. In general, component selection is preferred over tag selection.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
YES! When I was starting in Drupal knowing this would of been nice.
I agree with both you that FieldItemListInterface seems like a good place though.