Contrib.social

Tab navigation doesn't work when you've used the pagers

Open on Drupal.org →
Created on 8 April 2017, about 8 years ago
Updated 14 August 2023, over 1 year ago

When you have a calendar view created from template. When you use the pagination, the tabs no longer work.
E.g. you go to your calendar/day page and go to the next day. The URL shift to /calendar/day/20170409. This means the tabs are also formed similarly. E.g. /calendar/month/20170409 for the month tab. This URL doesn't work, because the month expects something like /calendar/month/201704
Changing the contextual filters so e.g. the month display uses the full date, makes sure not the entire month is shown.

This seems related to behaviour in core where arguments are added to the tabs when using them, so unsure on how to fix this.

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

🇧🇪Belgium daften

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Comment over 1 year ago →
    🇺🇸United States mortona2k Seattle

    Patch #23 fixed it for me. It works by altering the local tasks and removing extra arguments from the path. Maybe we should check in the css changes separately if those aren't necessary for this.

  • Comment 9 months ago →
    🇺🇸United States mortona2k Seattle

    Updated patch so it applies to beta2.

  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇨🇦Canada joelpittet Vancouver

    Thanks for keeping this up-to-date, I would agree with you that the CSS stuff needs to be moved to a separate fix if it's needed.
    Issue summary could explain this better

  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇮🇹Italy kopeboy Milan

    I see no mention of CSS issue in the summary nor in the patch, which does the job! Thank you! +3

  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇨🇦Canada joelpittet Vancouver

    There is still CSS code in the patches. This still needs work.

  • Merge request !49Resolve #2867991 "Tab navigation fix" → (Open) created by mortona2k
  • Comment 4 months ago →
    🇺🇸United States mortona2k Seattle

    2867991-tab_navigation_fix branch is going back to the fix from #5.

    With just this, the date contextual arguments are stripped from the other tabs so they are not broken.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024