Add tests for when a single supported branch has 2 security updates that are both not insecure

Created on 31 March 2017, over 7 years ago
Updated 18 July 2024, 4 months ago

Problem/Motivation

This issue began in 2017 with reporting that in #2804155: If the next minor version of core has a security release, status still says "Security update required!" even if the site is on an equivalent, secure release already , we discovered badly-outdated sites offer up all the security updates. That change meant that every security release was listed on the 'Available updates' page and the user was presented with an overwhelming set of choices. See original image .

In #17 this was reported fixed and this issue is to add test coverage so that doesn't happen again.

To test the fix, one can change the VERSION constant in Drupal.php to 8.1.10, which is used in the 'original image' and compare the results.

Proposed resolution

TBD
Possible solutions:

Remaining tasks

Items in #32
Add test case

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Update 

Last updated about 19 hours ago

  • Maintained by
  • 🇺🇸United States @tedbow
  • 🇺🇸United States @dww
Created by

🇺🇸United States drumm NY, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • First commit to issue fork.
  • 🇳🇿New Zealand quietone

    Issue Summary update and title change

  • Status changed to Needs review 7 months ago
  • 🇳🇿New Zealand quietone

    #31
    1. Already fixed.
    2. Added test case and removed @todo in UpdateContribTest.
    3. The MR for this is MR1615
    4. Check if these results are what is wanted:

  • 🇫🇮Finland simohell

    Since 1. was her the part affecting usability and was fixed already and the remaining task for this ticket is the test, I'm removing "usability" and needs usability review" tags. If we need to look at the usability aspects of the message (such as order of the recommendations, security updates on each supported minor etc.) it should prbably be a new issue.

    Attaching an example screnshot for 10.1.1 message for reference.

  • First commit to issue fork.
  • 🇺🇸United States smustgrave

    smustgrave changed the visibility of the branch 2865920-when-a-site to hidden.

  • Pipeline finished with Failed
    6 months ago
    Total: 643s
    #172698
  • 🇺🇸United States smustgrave

    smustgrave changed the visibility of the branch 2865920-when-a-site to active.

  • Status changed to Needs work 6 months ago
  • 🇺🇸United States smustgrave

    Rebased and fixed phpcs issue
    Hiding patches and old MR (but then un-hid_

    Will remove tests tag as test branch is showing failure.

    But can we update the MR 1594 for 11.x and include tests too please.

  • 🇺🇸United States xjm

    Unsure about the retitle and IS rewrite here. I didn't say the issue was fixed, just that it was mitigated by a recent change to d.o. The issue is still partly present AFAIK.

  • 🇳🇿New Zealand quietone

    According to #32.1 this original problem is fixed. tedbow states that they tested on 9.2 and "I think the problem is fixed but we should have test to confirm this doesn't happen again".

  • 🇫🇮Finland simohell

    As this was tagged, I had this queued for UX review meeting on May 10 but while preparing, I couldn't reproduce the original usability issue as it was already fixed as mentioned in #32. We didn't therefore do a formal review/recommendations and the related discussion is not included in the meeting recording.

  • 🇳🇿New Zealand quietone

    quietone changed the visibility of the branch 2865920-test-without-patch to hidden.

  • 🇳🇿New Zealand quietone

    quietone changed the visibility of the branch 2865920-test-without-patch to active.

Production build 0.71.5 2024