- 🇮🇳India himanshu_jhaloya Indore
Hi I am looking patch for D9 is there any patch for this same issue version 2.0.1
- 🇩🇰Denmark erik_petra
Patch at #55 did not apply successfully for me through composer patches, so I fixed it and also fixed some formatting. Patch is for 2.0.1, due to Drupal 10 upgrades.
- 🇬🇧United Kingdom ChristianSanders
Unfortunately the latest patch (comment #56) isn't working as desired.
I have a view with 9 results.
Initially set to display 7 and load 6 thereafter.
The initial items of 7 display, but because my view results don't have enough results to reach an additional 6 (9 results, 7 of initial page load, therefore 2 more to load in) the pager doesn't load.
I've tested by changing initially show 4 items and then 3 thereafter on load. The pager displays, loads in my 3, then no more pager, cause I have 2 items left, not 3.
This is all tested via AJAX.
- last update
over 1 year ago Patch Failed to Apply - 🇬🇧United Kingdom ChristianSanders
Added a patch that solves my comment in 58.
- 🇬🇧United Kingdom ChristianSanders
Uploaded the files the wrong way around perviously - sorry!
- last update
over 1 year ago 2 pass - 🇩🇪Germany Anybody Porta Westfalica
Thanks @ChristianSanders could you prepare that as MR perhaps, please?
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - 🇬🇧United Kingdom ChristianSanders
@Anybody done - https://git.drupalcode.org/project/views_infinite_scroll/-/merge_request... (hope i've done this correctly - this is my first time contributing a patch via an MR!) Thanks :)
- Status changed to Needs work
over 1 year ago 11:12am 7 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thanks @ChristianSanders. Looking quite good, but there is a conflict left. Perhaps it was based on an older branch? Could you resolve that one?
Here you can see the resulting diff from the MR: https://git.drupalcode.org/project/views_infinite_scroll/-/merge_request...
In the end it should be equal to your one? - last update
over 1 year ago 2 pass - 🇮🇳India himanshu_jhaloya Indore
I was facing the same issue but checked with views_infinite_scroll-2852080-2852080-different-item-count this branch it is working fine for me thanks @christiansanders
- 🇩🇪Germany Anybody Porta Westfalica
Thanks. So the last step here seems to be to add test coverage?
- 🇺🇦Ukraine rsych
I checked the patch from #61, and there is another bug. My steps:
1. I set 6 items to show on load
2. I set 3 items to add on each "load more" click (I use the button)
Result: when I have 3 items in total, no "load more" button is shown (correct). But after creating another node, I have this behavior: it shows 4 nodes and (here's the error itself) the "load more" button. After clicking on this button, it disappears (without adding any item because everything is already displayed). - 🇻🇳Vietnam ypx
This is an updated patch file to fix the bug reported at #68
The number of pages needs to be recalculated
When creating a pager we set total items = current_total_items + (items_per_page - initial_items). - First commit to issue fork.
- 🇺🇸United States DamienMcKenna NH, USA
I updated the merge request with the changes from #69 (and the latest changes from the 2.0.x branch).
In my local testing the new options work well, thank you all.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks, still needs tests (FunctionalJavascript) as last step, right? Who's our hero? 🦸🦸♀️