🇬🇧United Kingdom @ChristianSanders

Account created on 5 November 2013, about 11 years ago
#

Merge Requests

Recent comments

🇬🇧United Kingdom ChristianSanders

Added a 1.61 version for those that don't want to upgrade commerce_core as a result of needing to update this module to 1.70

🇬🇧United Kingdom ChristianSanders

I'm experiencing this issue also. Drupal 10.2.6, all commerce modules up to date.

It's only happening with Anon users - no other contrib modules in the stacktrace.
The only custom code is from our own Shipping pane, but all it does is build the form from the parent pane (the commerce_shipping pane) $pane_form = parent::buildPaneForm($pane_form, $form_state, $complete_form); and then does some changes with some of the labelling. But other than that, it's a stock setup.

🇬🇧United Kingdom ChristianSanders

Ran in to comment 4's issue today and this patch fixes our issues - thank you!

🇬🇧United Kingdom ChristianSanders

@Anybody done - https://git.drupalcode.org/project/views_infinite_scroll/-/merge_request... (hope i've done this correctly - this is my first time contributing a patch via an MR!) Thanks :)

🇬🇧United Kingdom ChristianSanders

Uploaded the files the wrong way around perviously - sorry!

🇬🇧United Kingdom ChristianSanders

Added a patch that solves my comment in 58.

🇬🇧United Kingdom ChristianSanders

Unfortunately the latest patch (comment #56) isn't working as desired.

I have a view with 9 results.

Initially set to display 7 and load 6 thereafter.

The initial items of 7 display, but because my view results don't have enough results to reach an additional 6 (9 results, 7 of initial page load, therefore 2 more to load in) the pager doesn't load.

I've tested by changing initially show 4 items and then 3 thereafter on load. The pager displays, loads in my 3, then no more pager, cause I have 2 items left, not 3.

This is all tested via AJAX.

Production build 0.71.5 2024