- πΊπ¦Ukraine s.kulyk
New patches are not compatible with old ones because of schema changes. Updating this patch to be compatible with latest version because it works for me.
- last update
over 1 year ago 29 pass, 2 fail - Status changed to RTBC
over 1 year ago 7:07am 30 July 2023 - π¨π¦Canada joseph.olstad
RTBC patch from comment #94 labelled as patch 92 as it has tests, functionality works, great job! This is definately needed and should go in asap.
Patch #96 has one additional fail and is based on a much earlier implementation and lacks tests. Lets go with the patch from comment #94 please as the patch from #94 has tests and it works flawlessly.
Just to be clear, this is the patch I am setting as RTBC: https://www.drupal.org/files/issues/2023-01-11/panels_custom_attributes_... β
- π¨π¦Canada joelpittet Vancouver
Ok I committed #94 thanks all contributors, I tried to give credit where due and gave authorship to @nevergone for the tests because they tend to be the trickiest to get help with but are the real reason I'm committing this.
@eclipsegc mentioned (on slack) there are likely other modules out there that could accomplish this feature but bringing the expected features from previous versions seems reasonable.
- Status changed to Fixed
over 1 year ago 4:19pm 24 August 2023 -
joelpittet β
committed 5ff97e75 on 8.x-4.x authored by
nevergone β
Issue #2849867 by piggito, nevergone, kevin.pfeifer, dobrzyns, Sseto,...
-
joelpittet β
committed 5ff97e75 on 8.x-4.x authored by
nevergone β
Automatically closed - issue fixed for 2 weeks with no activity.