- Status changed to Needs work
over 1 year ago 1:16pm 2 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ # Access to this path is not restricted. This is notated as _access: 'TRUE'. _access: 'TRUE'
That does not explain why it is not restricted.
package: OOP Example modules core: 8.x dependencies: - - oop_examples + - drupal:oop_examples
That is not a Drupal core module. Its namespace cannot start with drupal:.
- $s = t('This car has') . ' '; + $s = $this->t('This car has') . ' '; $s .= $this->doors; - $s .= ' ' . t('doors.'); + $s .= ' ' . $this->t('doors.'); return $s;
Since that code is changed, translatable strings need to use placeholders. It is a security issue, to pass user input to
$this->t()
without sanitizing it. - Status changed to Needs review
over 1 year ago 9:44am 20 September 2023 - Issue was unassigned.
- Status changed to Needs work
5 months ago 5:58am 18 July 2024 - 🇵🇭Philippines cleavinjosh
Hi @Amit.Rawat777,
I applied patch #6 and it was applied smoothly. However, I still encountered some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
.➜ oop_examples git:(8.x-1.x) curl https://www.drupal.org/files/issues/2023-09-20/codstn-2834254-6.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 99952 100 99952 0 0 186k 0 --:--:-- --:--:-- --:--:-- 186k patching file oop_example_04/oop_example_04.module patching file oop_example_04/oop_example_04.routing.yml patching file oop_example_04/src/Classes/Car.php patching file oop_example_04/src/Classes/Motorcycle.php patching file oop_example_04/src/Classes/Vehicle.php patching file oop_example_04/src/Controller/OopExample04Controller.php patching file oop_example_05/oop_example_05.info.yml patching file oop_example_05/oop_example_05.module patching file oop_example_05/oop_example_05.routing.yml patching file oop_example_05/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_05/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_05/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_05/src/Controller/OopExample05Controller.php patching file oop_example_06/oop_example_06.module patching file oop_example_06/oop_example_06.routing.yml patching file oop_example_06/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_06/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_06/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_06/src/Controller/OopExample06Controller.php patching file oop_example_07/oop_example_07.module patching file oop_example_07/oop_example_07.routing.yml patching file oop_example_07/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_07/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_07/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_07/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_07/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_07/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_07/src/Controller/OopExample07Controller.php patching file oop_example_08/oop_example_08.module patching file oop_example_08/oop_example_08.routing.yml patching file oop_example_08/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_08/src/BusinessLogic/Fruit/Banana.php patching file oop_example_08/src/BusinessLogic/Fruit/Fruit.php patching file oop_example_08/src/BusinessLogic/Fruit/Orange.php patching file oop_example_08/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_08/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_08/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_08/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_08/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_08/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_08/src/Controller/OopExample08Controller.php patching file oop_example_09/oop_example_09.module patching file oop_example_09/oop_example_09.routing.yml patching file oop_example_09/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_09/src/BusinessLogic/Fruit/Banana.php patching file oop_example_09/src/BusinessLogic/Fruit/Fruit.php patching file oop_example_09/src/BusinessLogic/Fruit/JuiceInterface.php patching file oop_example_09/src/BusinessLogic/Fruit/Mango.php patching file oop_example_09/src/BusinessLogic/Fruit/Orange.php patching file oop_example_09/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_09/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_09/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_09/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_09/src/BusinessLogic/Vehicle/DriveInterface.php patching file oop_example_09/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_09/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_09/src/Controller/OopExample09Controller.php patching file oop_example_10/oop_example_10.module patching file oop_example_10/oop_example_10.routing.yml patching file oop_example_10/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_10/src/BusinessLogic/Fruit/Banana.php patching file oop_example_10/src/BusinessLogic/Fruit/Fruit.php patching file oop_example_10/src/BusinessLogic/Fruit/FruitInterface.php patching file oop_example_10/src/BusinessLogic/Fruit/JuiceInterface.php patching file oop_example_10/src/BusinessLogic/Fruit/Mango.php patching file oop_example_10/src/BusinessLogic/Fruit/Orange.php patching file oop_example_10/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_10/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_10/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_10/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_10/src/BusinessLogic/Vehicle/DriveInterface.php patching file oop_example_10/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_10/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_10/src/BusinessLogic/Vehicle/VehicleInterface.php patching file oop_example_10/src/Controller/OopExample10Controller.php patching file oop_example_11/oop_example_11.module patching file oop_example_11/oop_example_11.routing.yml patching file oop_example_11/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_11/src/BusinessLogic/Driver/Driver.php patching file oop_example_11/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_11/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_11/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_11/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_11/src/BusinessLogic/Vehicle/DriveInterface.php patching file oop_example_11/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_11/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_11/src/BusinessLogic/Vehicle/VehicleInterface.php patching file oop_example_11/src/Controller/OopExample11Controller.php patching file oop_example_12/oop_example_12.module patching file oop_example_12/oop_example_12.routing.yml patching file oop_example_12/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_12/src/BusinessLogic/Common/ColorableFactory.php patching file oop_example_12/src/BusinessLogic/Fruit/Banana.php patching file oop_example_12/src/BusinessLogic/Fruit/Fruit.php patching file oop_example_12/src/BusinessLogic/Fruit/Orange.php patching file oop_example_12/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_12/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_12/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_12/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_12/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_12/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_12/src/Controller/OopExample12Controller.php patching file oop_example_13/oop_example_13.module patching file oop_example_13/oop_example_13.routing.yml patching file oop_example_13/src/BusinessLogic/Common/ColorInterface.php patching file oop_example_13/src/BusinessLogic/Common/ColorableFactory.php patching file oop_example_13/src/BusinessLogic/Common/ColorableFactoryInterface.php patching file oop_example_13/src/BusinessLogic/Fruit/Banana.php patching file oop_example_13/src/BusinessLogic/Fruit/Fruit.php patching file oop_example_13/src/BusinessLogic/Fruit/FruitFactory.php patching file oop_example_13/src/BusinessLogic/Fruit/Orange.php patching file oop_example_13/src/BusinessLogic/Vehicle/Car/Car.php patching file oop_example_13/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php patching file oop_example_13/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaCamry.php patching file oop_example_13/src/BusinessLogic/Vehicle/Car/Toyota/ToyotaYaris.php patching file oop_example_13/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php patching file oop_example_13/src/BusinessLogic/Vehicle/Vehicle.php patching file oop_example_13/src/BusinessLogic/Vehicle/VehicleFactory.php patching file oop_example_13/src/Controller/OopExample13Controller.php patching file src/Controller/OopExamplesController.php ➜ oop_examples git:(8.x-1.x) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml oop_examples FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/oop_example_13.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/oop_example_13.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/Controller/OopExample13Controller.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/BusinessLogic/Fruit/Fruit.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_13/src/BusinessLogic/Vehicle/Vehicle.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_examples.info.yml ------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 1 | WARNING | "core_version_requirement" property is missing in the info.yml file ------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/oop_example_12.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/oop_example_12.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/Controller/OopExample12Controller.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Fruit/Fruit.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Vehicle/Vehicle.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_12/src/BusinessLogic/Common/ColorableFactory.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_12\BusinessLogic\Fruit\Orange. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/oop_example_08.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/oop_example_08.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/Controller/OopExample08Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_08\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/BusinessLogic/Fruit/Fruit.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_08/src/BusinessLogic/Vehicle/Vehicle.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_06/oop_example_06.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_06/oop_example_06.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_06/src/Controller/OopExample06Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_06\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_06/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_06/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/oop_example_07.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/oop_example_07.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/src/Controller/OopExample07Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_07\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_07/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_examples.routing.yml ------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction ------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/oop_example_09.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/oop_example_09.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/Controller/OopExample09Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_09\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/BusinessLogic/Fruit/Fruit.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_09/src/BusinessLogic/Vehicle/Vehicle.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/oop_example_10.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/oop_example_10.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/src/Controller/OopExample10Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_10\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_10/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/oop_example_11.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/oop_example_11.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/src/Controller/OopExample11Controller.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/src/BusinessLogic/Vehicle/Car/Toyota/Toyota.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_11/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_05/oop_example_05.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_05/oop_example_05.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_05/src/Controller/OopExample05Controller.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_05\BusinessLogic\Vehicle\Car\Car. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_05/src/BusinessLogic/Vehicle/Car/Car.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_05/src/BusinessLogic/Vehicle/Motorcycle/Motorcycle.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_04/oop_example_04.routing.yml --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_04/oop_example_04.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | WARNING | "core_version_requirement" property is missing in the info.yml file 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/oop_examples/oop_example_04/src/Controller/OopExample04Controller.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\oop_example_04\Classes\Car. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ Time: 866ms; Memory: 12MB ➜ contrib
Please check and advise.
Thank you. - 🇮🇹Italy apaderno Brescia, 🇮🇹
Let's create a merge request, now that patches are no longer tested.
- Status changed to Needs review
5 months ago 5:32am 19 July 2024 - Status changed to Needs work
5 months ago 8:06am 19 July 2024 - Assigned to cleavinjosh
- Issue was unassigned.
- Status changed to Needs review
5 months ago 11:37am 23 July 2024 - 🇵🇭Philippines cleavinjosh
Hi @avpaderno,
I have addressed some of your reviews.
Please check and advise. Thank you.
- Status changed to Needs work
5 months ago 4:34pm 24 July 2024 - Status changed to Needs review
5 months ago 1:37pm 31 July 2024 - 🇵🇭Philippines cleavinjosh
Hi @avpaderno,
I have addressed your remaining reviews.
Please recheck and advise.
Thank you.