Replace views results summary with text area

Created on 23 November 2016, over 8 years ago
Updated 23 February 2023, over 2 years ago

We have a lot of duplicated functionality in the Views Results Summary and Text Area. Results Summary made sense when Views couldn't be sure that Tokens was installed but now that Tokens is in core, Text Area should be able to provide all the functionality of Results Summary. It will be relatively simple to add the missing tokens to Text Area to reach functional parity.

Here is the current status of available tokens in each:

Results Summary - Text Area
@start - Needs Token
@end - Needs Token
@total - [view:total-rows]
@label - [view:label]
@per_page - [view:items-per-page]
@current_page - [view:current-page]
@current_record_count - Needs Token
@page_count - [view:page-count]

I recommend that we add the missing tokens to Text Area and work towards migration and removal of Results Summary.

📌 Task
Status

Needs work

Version

10.1

Component
Views 

Last updated about 8 hours ago

Created by

🇨🇦Canada jamesrward

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇯🇴Jordan Qusai Taha Amman

    Patch #11 Working fine with me.

    Thank you!

  • Status changed to Needs work over 2 years ago
  • The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • 🇮🇳India nikhil_110

    Re-roll patch #11 and try to Fix Cs issue..& attach interdiff file...

  • Status changed to Needs review over 2 years ago
  • Status changed to Needs work over 2 years ago
  • 🇳🇱Netherlands Lendude Amsterdam

    So if we are going to do this here, we can take this of the plan queue and just make it a task.

    Removed the line about oping issue to track other things, we need to do all the work in this issue.

    1. This needs tests (hopefully Results Summary has some for these tokens we can use?)
    2. Deprecate Result Summary
    3. Migrate Results Summary to Text Area via an update path (?)

    As pointed out before, that last part might be tricky, but we should try

Production build 0.71.5 2024