Book Navigation Block does not sort Books by weight

Created on 18 November 2016, about 8 years ago

Updated 4 September 2024, 3 months ago

The Book Navigation Block does not sort the list of books by weight.

A weight can be assigned to the first page of a book through the outline tab, however it has no effect.

I've created a patch and will submit it shortly. It's my first patch!

NB: this concerns the order of multiple books, NOT ordering pages within a book.

Steps to Reproduce:

Enable the book module (it's in core)
Create two books:
Add content > Book page >
- Title: 'My first book'
- Expand 'Book outline' settings - choose 'Create a new book'
- Then do the same for 'My second book'
Structure > Block layout > Add a Book navigation block in the sidebar
(Use the default settings.)
Observe that it shows 'My first book' then 'My second book'
Click the second book, Outline tab, change the weight to negative (so it should appear above book 1 in the list)
Observe list is still in the same (wrong) order.
Apply patch, refresh, order should have changed.

Simple sort of books using sortByWeightElement.

- Write tests.

None.

None.

None.

🐛 Bug report

Status

Needs work

Version

2.0

Component

Book →

Last updated 3 days ago

Created by

🇺🇸United States mtnguru

Live updates comments and jobs are added and updated live.

Needs reroll
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
Status changed to Needs work 7 months ago5:37pm 26 April 2024
Comment 7 months ago →
🇺🇸United States smustgrave
Comment 3 months ago →
🇺🇸United States smustgrave
@smustgrave opened merge request.
Comment 2 months ago →
🇺🇸United States smustgrave
Comment about 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024