Contrib.social

Remove the "Allow embedded displays" checkbox from BasicSettingsForm

Open on Drupal.org →
Created on 4 July 2016, over 8 years ago
Updated 7 February 2023, almost 2 years ago

Problem/Motivation

Since Drupal 8 embedded displays are shown all the time. I think noone complained about it, so we should keep it that way.

There is though still some UI code in BasicSettingsForm which does not have any actual impact.

Proposed resolution

  • Remove
        $form['basic']['ui_show_display_embed'] = array(
      '#type' => 'checkbox',
      '#title' => t('Allow embedded displays'),
      '#description' => t('Embedded displays can be used in code via views_embed_view().'),
      '#default_value' => $config->get('ui.show.display_embed'),
    );

    from \Drupal\views_ui\Form\BasicSettingsForm

  • Remove it from core/modules/views/config/install/views.settings.yml:14
  • Write an update path to remove the setting from existing configuration
  • Remove the TODO from \Drupal\views\Plugin\views\display\Embed

Remaining tasks

Implement
Review
Commit

User interface changes

NA

API changes

NA

Data model changes

NA

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Views UI  →

Last updated 21 days ago

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇮🇳India nayana_mvr

    Verified the patch #27 and tested it on Drupal version 10.1.x. The patch applied cleanly and I have added the before and after screenshots for reference. Need RTBC+1

  • Comment almost 2 years ago →
    🇮🇳India sonam.chaturvedi Pune

    Verified and tested patch #27 on 10.1.x-dev.
    Patch applies cleanly.

    Test Result: "Allow embedded displays" checkbox is now removed from BasicSettingsForm.
    RTBC+1

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇳🇱Netherlands Lendude Amsterdam
    +++ b/core/modules/views/views.install
@@ -18,3 +18,10 @@ function views_install() {
+ * Set default values for enabled/expanded flag on page displays.

    Pretty sure that is not what this does ;)

    Also per #9 Note: You need a save call, otherwise, this doesn't work :)
    ^^ This means we need an upgrade test for this.

    Also the removed test coverage looks ok, so how come this doesn't do anything in the UI (I checked, it really doesn't) but it still passes?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024