- last update
over 1 year ago 29,878 pass - π³π±Netherlands Lendude Amsterdam
This seems to have gotten fixed in the intervening years, this test should be green
- last update
over 1 year ago CI aborted - last update
over 1 year ago 29,874 pass, 2 fail - π³π±Netherlands Lendude Amsterdam
Ah wait, not fixed, it has to be NULL to fail, see test
- π³π±Netherlands Lendude Amsterdam
Ah wait, not fixed, it has to be NULL to fail, see test
The last submitted patch, 42: 2730807-42-TEST_ONLY.patch, failed testing. View results β
- last update
over 1 year ago 29,880 pass - π³π±Netherlands Lendude Amsterdam
Here is a fix that implements #23, no interdiff since its a different approach than previously
- π³π±Netherlands Lendude Amsterdam
If we feel this is a good fix, we can close π When creating a theme, if you leave the description field empty in the themename.info.yml file, it throws a white screen error Closed: duplicate too
- πΊπΈUnited States smustgrave
So the IS points to #21 which is to throw a MissingRequiredInfoKeyException but is it now just to display a message?
- π³π±Netherlands Lendude Amsterdam
We can't/shouldn't throw an exception for description as if it is required, because it's not required. So the solution is now to make sure the defaults are used if something is set to NULL. I removed #21 from the IS.
- Status changed to RTBC
over 1 year ago 6:40pm 23 July 2023 - πΊπΈUnited States smustgrave
Gotcha.
Verified the problem described in the IS
Edited the action module description to bedescription:
Got a fatal error
Applied patch #45 and no issue now. - Status changed to Fixed
over 1 year ago 8:04am 24 July 2023 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- π³π±Netherlands Lendude Amsterdam
Thanks! I forgot to tag with ddd23, fixing that now.
Automatically closed - issue fixed for 2 weeks with no activity.