[regression] getEntity() doesn't always return entity, which results in add comment field not working in Views

Created on 28 April 2016, over 8 years ago

Updated 6 February 2023, almost 2 years ago

Drupal\views\Plugin\views\field\FieldPluginBase\GetEntity is documented as returning an entity.
However if only returns an entity if one of two conditions are true.

    if ($relationship_id == 'none') {
      return $values->_entity;
    }
    elseif (isset($values->_relationship_entities[$relationship_id])) {
      return $values->_relationship_entities[$relationship_id];
    }

otherwise it returns nothing;
Mine is crashing I think when a non-required relationship is not present.

This is problematic in Drupal\views\Plugin\views\field\Field::getItems() because createEntityForGroupBy expects an entity. I think this problem was introduced in 8.1
$this->createEntityForGroupBy($this->getEntity($values), $values);

This also results in the add comment link not being a link in Views. Steps to reproduce from #2671494: Add Comment Field Not Appearing in Views → :

Create a new view 'Blog' as a page, Unformatted List, Fields, paged 10, URL /blog
Add field for 'Content: Add comment link'
View the page at /blog
The field is empty

🐛 Bug report

Status

Closed: duplicate

Version

10.1 ✨

Component

Views →

Last updated about 5 hours ago