[policy, no patch] Policy to help less interested Patch move forward.

Created on 14 April 2016, over 8 years ago
Updated 5 July 2023, over 1 year ago

Problem/Motivation

Many issues have a patch but no reviewers. They will never commit into CORE.

Few of my issues are 4+ years old. Some of them older enough to close because no more D6 / browser bugs..etc. As my experiences, I tried to post to IRC, TWITTER, BLOG..etc, but no helps. (OK, I have no good Drupal Friend)
(I also dropped to patch complicated issue because that's hopeless all time.)

Let's make rules to help these issues move on, e.g.:

If the waiting time is passing X period, contributors able to self-signed their patches. We can set a new Review Status to "Self-Signed" or something else. Therefore, anyone is interested, or subsystem maintainers should take care of them.

If you're one of:

Subsystem maintainers:
After 3 ~ 6 months: Self-sign sub-modules patches.

Top 30/50 developers:
After 9 months: Self-sign their patches (in their professions. e.g., If you often contribute to JS, you can self-sign JS patches only)

Other members:
After 1 years+

We can start with more strict rules at beginning:
CSS issues: after 1 years+
PHP issues: after 2 years+
JS issues: after 3 years+

Proposed resolution

Use and update Getting an issue addressed sooner .

There has been no support for the following suggestions, in this issue or in Slack, #45 🌱 [policy, no patch] Policy to help less interested Patch move forward. Closed: outdated . They are being left here so the ideas are easy to find.

See #3317273: Set up a Drupal.org GitLab issues bot .

Suggestions:

Remaining tasks

Build consensus an options to implement.

🌱 Plan
Status

Closed: outdated

Version

11.0 🔥

Component
Other 

Last updated about 1 hour ago

Created by

🇭🇰Hong Kong droplet

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    There has not been any discussion here for 7 years. Several proposals have been made which were added to the Issue Summary 2 years ago. There has been no response since then.

    Lately a great deal of work has been done, lead by smustgrave to make the size of the 'Needs review' queue manageable, They are doing that by actually doing the reviews, asking questions in various Slack channels and sometimes also finalizing patches. This has resulted in a significant drop of the number of issues with the 'Needs Review' status. And most importantly, most of those issues are being committed and Fixed.

    So, is there anything else to do here? Is there anything in the proposals that anyone would like explore or implement?

  • 🇳🇿New Zealand quietone

    I asked in #contribute about this. smustgrave, FeyP, andy-blum, dww and cilefen responded. There was no objection to closing this issue.

    In the discussion, the topic of self-RTBC was raised. It was pointed out that this is not good practice as it defeats the purpose of code review, which is to get more eyes on the change. And, tt also puts more work on the core committers. Although, at least one experienced contributes will self RTBC when making minor formatting changes.

    There were two suggestions that someone may wish to follow up on.

    1. For an auto comment for issues tagged 'Needs usability review' that states that there is a regular usability review meeting.
    2. An auto triage bot that makes suggestions when a new issue is filed

    For the first point, there are currently 142 Open issues that are tagged 'Needs usability review'. I wonder how many of those are stalled because people do not know how to prepare for and join the review?

    I am not yet closing this issue because i need to think about how to address the two suggestions (and I am on holiday right now). I will ask in the Slack thread if anyone wants to make issues for those.

  • Status changed to Closed: outdated over 1 year ago
  • 🇳🇿New Zealand quietone

    Thank you, FeyP, for adding the ideas from the Slack discussion to an existing issue about an automated issue bot. That issue is #3317273: Set up a Drupal.org GitLab issues bot .

    Now that is done there is nothing more to do here, so I am closing this as outdated.

  • 🇳🇿New Zealand quietone

    Adding parent to help find related issues

Production build 0.71.5 2024