- 🇳🇿New Zealand quietone
There has not been any discussion here for 7 years. Several proposals have been made which were added to the Issue Summary 2 years ago. There has been no response since then.
Lately a great deal of work has been done, lead by smustgrave to make the size of the 'Needs review' queue manageable, They are doing that by actually doing the reviews, asking questions in various Slack channels and sometimes also finalizing patches. This has resulted in a significant drop of the number of issues with the 'Needs Review' status. And most importantly, most of those issues are being committed and Fixed.
So, is there anything else to do here? Is there anything in the proposals that anyone would like explore or implement?
- 🇳🇿New Zealand quietone
I asked in #contribute about this. smustgrave, FeyP, andy-blum, dww and cilefen responded. There was no objection to closing this issue.
In the discussion, the topic of self-RTBC was raised. It was pointed out that this is not good practice as it defeats the purpose of code review, which is to get more eyes on the change. And, tt also puts more work on the core committers. Although, at least one experienced contributes will self RTBC when making minor formatting changes.
There were two suggestions that someone may wish to follow up on.
- For an auto comment for issues tagged 'Needs usability review' that states that there is a regular usability review meeting.
- An auto triage bot that makes suggestions when a new issue is filed
For the first point, there are currently 142 Open issues that are tagged 'Needs usability review'. I wonder how many of those are stalled because people do not know how to prepare for and join the review?
I am not yet closing this issue because i need to think about how to address the two suggestions (and I am on holiday right now). I will ask in the Slack thread if anyone wants to make issues for those.
- Status changed to Closed: outdated
over 1 year ago 9:05pm 2 June 2023 - 🇳🇿New Zealand quietone
Thank you, FeyP, for adding the ideas from the Slack discussion to an existing issue about an automated issue bot. That issue is #3317273: Set up a Drupal.org GitLab issues bot → .
Now that is done there is nothing more to do here, so I am closing this as outdated.