Add useful watchdog logging

+1 on this. Would absolutely make sense to track if someone was logged out. This should be configurable.

aaron.ferris → made their first commit to this issue’s fork.

Raised an initial MR for this, open to suggestions to where else we want to log events but ive replaced the @todo in the codebase.

Followed the Core user module approach for the log entry, wording etc, I did toy with the idea of including more info, session ID etc but didn't know if we felt that would be worth it.

Really nice work @aaron.ferris, thank you! :)

Regarding your comments I agree it wouldn't make much sense to log the other variables in that function.
What might be improved:

• $this->loggerFactory->get('session_limit') could be set as $this->sessionLimitLogger in the constructor. That would be more typical.
• The username could be put more in front of the message
• It would be great to log the session limit (count) that caused the logout, which would be helpful for debugging but also to understand why exactly the user was logged out

But anyway, the current state is already better than the @todo before :D

Thanks for the feedback, ill get onto those points.

LGTM! The only thing missing is an update hook prepopulating the new "session_limit_log_events" config with the default value "false". Otherwise, "session_limit_log_events" will be null for already existing site installations.

Great stuff! 👍
Looks perfect now! RTBC!

Great work! Thank you all! 🍰
Committed!

Automatically closed - issue fixed for 2 weeks with no activity.