- First commit to issue fork.
- Merge request !11748feat: Add LenientConfigSchemaChecker to validate config schema on save. Only... β (Open) created by bbrala
- π³π±Netherlands bbrala Netherlands
Updated the CR, updated the message to be more helpful and also show a link to the documentation. Tests seem green. Let's see if we can continue here.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³π±Netherlands bbrala Netherlands
Removed new forbidden word "please" from the message.
- πΊπΈUnited States smustgrave
1 small comment but
Consider adding a todo to move it out of the Testing namespace in D9.
And decide on the namespace. There was an initial suggestion of 'Drupal\Core\Config\Schema\ConfigSchemaChecker'. And later the patch used '\Drupal\Core\Config\Devel\ConfigSchemaChecker', which was changed to '\Drupal\Core\Config\Development\ConfigSchemaChecker'.
Is the current namespace '\Drupal\Core\Config\Development\ConfigSchemaChecker' the one to use or something else?
Is the todo still needed?
Has the namespace been decided?
- π³π±Netherlands bbrala Netherlands
We can decide the namespace, i think this placement is all good.
- π³π±Netherlands bbrala Netherlands
Applied suggestion for grammar and adjusted contructor.
Nit: add
readonly
to the promoted properties. Otherwise can RTBC.- πΊπΈUnited States smustgrave
Re-run seemed to do the trick. Believe all feedback has been addressed
- π¬π§United Kingdom alexpott πͺπΊπ
The CR is no longer correct as the class is not moving. I do think that the CR should exist - it should detail that by default if you use the development.services.yml you will can warnings when saving configuration that does not comply with schema. Once the CR is updated this can be set back to RTBC. The solution looks elegant and it's great that this emits warnings rather than errors.
-
alexpott β
committed 733dc5fc on 11.x
Issue #2625212 by faline, bbrala, cilefen, bircher, okay19, krishnan.n,...
-
alexpott β
committed 733dc5fc on 11.x