- 🇺🇸United States smustgrave
Anyone know if still an issue in D10? There have been tons of works around config schema
Found while porting the Browsersync module to D8. →
If you hook_form_alter() some elements into \Drupal\system\Form\ThemeSettingsForm, all of the values are saved into the theme config object automatically. However there's no schema for those pieces of configuration and as far as I can see no way of declaring a schema for them. Based on what I've reviewed contrib modules should be adding their config schemas to theme_settings.third_party.*.
The fact that these settings get saved automatically to the top level of theme config results in config schema mismatches that can be seen with https://www.drupal.org/project/config_inspector → .
Don't save unknown keys in theme_settings_convert_to_config(), only save a whitelist of keys from core.
Patch
Tests
Review
n/a
TBD
TBD, should be none.
Postponed: needs info
11.0 🔥
Last updated
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
A documentation change is requested elsewhere. For Drupal core (and possibly other projects), once the change has been committed, this status should be recorded in a change record node.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Anyone know if still an issue in D10? There have been tons of works around config schema