"Recent content", the page coming from tracker module doesn't work properly.
The "new comments" link is not displayed.
Steps to reproduce:
1. Install brand new site.
2. Log in with the admin user.
3. Enable tracker module.
4. Create another user, and make it admin (just for permissions sake).
5. Open incognito or a different browser and log in with the second user).
6. Create an article and forum post with the second user.
7. Comment on the article and forum post with the second user.
8. Go to /activity on the first user.
You should see "1 new" on the comments tab, but it doesn't show.
The request to: http://drupal86.dev.localhost/comments/render_new_comments_node_links
Returns:
TypeError: Argument 1 passed to Drupal\comment\CommentManager::getCountNewComments() must implement interface Drupal\Core\Entity\EntityInterface, null given, called in /Users/ariel/Sites/drupal/drupal86.git/core/modules/comment/src/Controller/CommentController.php on line 333 in Drupal\comment\CommentManager->getCountNewComments() (line 180 of /Users/ariel/Sites/drupal/drupal86.git/core/modules/comment/src/CommentManager.php).
This is actually because the POST node_ids[] are null, and the reason for that is #2915993: Adjust render_new_comments_node_links to fix issues → , which is the traversing of the table column HTML tags could fail on some browsers/OSs/themes. However, even by fixing that, you also get:
Error: Call to a member function getSetting() on null in Drupal\comment\CommentStorage->getNewCommentPageNumber() (line 135 of /Users/ariel/Sites/drupal/drupal86.git/core/modules/comment/src/CommentStorage.php).
And the reason for that is also both mentioned on the comments here and on #2915993: Adjust render_new_comments_node_links to fix issues → and is because you are not sending anywhere the comment field name and that's needed for this to work.
No interdiff really as it's a whole different approach.
Active
1.0
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This extension is deprecated and scheduled for removal in Drupal 11.
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.
It will be moved to the contributed extension → once the Drupal 11 branch is open.
