UserAccessControlHandler::checkAccess() fails to add a user cache context where needed

Still valid, sent the patch for a re-test since it looks like it'd still apply, we'll still need to update those tests if it's the same two test failures.

I have attached a patch for 11.x. Patch #3, does not apply to 11.x so not adding interdiff.

Still need a test showing the bug.

+++ b/core/modules/user/src/UserAccessControlHandler.php
+++ b/core/modules/user/src/UserAccessControlHandler.php
@@ -56,7 +56,7 @@ protected function checkAccess(EntityInterface $entity, $operation, AccountInter

@@ -56,7 +56,7 @@ protected function checkAccess(EntityInterface $entity, $operation, AccountInter
         }
         // Users can view own profiles at all times.
         elseif ($account->id() == $entity->id()) {
-          return AccessResult::allowed()->cachePerUser();
+          return AccessResult::allowedIf($account->id() == $entity->id())->cachePerUser();
         }

The code flow used to be a switch, but is now an if/elseif, so I don't think this will work the same way at all - it's the final else that needs the user cache content adding, and the condition added here will always be true.

Tried to address the failures in #18.

Aditi Saraf → made their first commit to this issue’s fork.