- First commit to issue fork.
- πΊπΈUnited States kentr Durango, CO
It looks like the Remove checkboxes have been fixed.
I found other cases: The textfields for numerical filters. I think it's called the "in operator".
I think I have a fix, and will update the IS and create an MR. I think this is testable in Nightwatch.
- πΊπΈUnited States kentr Durango, CO
I was wrong about the Remove checkboxes. They are still missing labels.
The strange thing is that it looks like they're not supposed to be visible. There's this comment in the code, and they don't appear when the admin theme is Stark.
// No title is given here, since this input is never displayed. It is
// only triggered by JavaScript. - πΊπΈUnited States kentr Durango, CO
Yeah, the Remove checkboxes have
display: none
in the views_ui module and in Claro.Claro then overrides that with
.form-boolean
. It's probably an accident because it's a generic selector. I haven't checked Gin.I think there's a bigger issue of whether they should be visible at all, but I'm planning to give them a hidden label due to π Test that all form elements have a title for accessibility Needs work (which will require a
#title
property). - @kentr opened merge request.
- πΊπΈUnited States kentr Durango, CO
The Remove checkboxes are also visible in Gin. Based on #3375806-14: Views 'Rearrange' dialog show the 'Remove' checkbox, which should be visually hidden β , it looks like they should be hidden with the
js-hide
class in another issue.