Ensure no empty strings are fed to TranslatableMarkup

Could the issue summary be updated for what's needed here? We looking to throw another exception if empty?

I'm getting a InvalidArgumentException: $string ("") must be a string. in Drupal\Core\StringTranslation\TranslatableMarkup->__construct() (line 132 of /opt/drupal/web/core/lib/Drupal/Core/StringTranslation/TranslatableMarkup.php).

And I was hoping to go around it with patch #13, but it doesn't work on Drupal 10.3.2.

Cannot access offset can be symptom-ish for empty string - however I wonder if this is related:

Cannot access offset of type Drupal\Core\StringTranslation\TranslatableMarkup in isset or empty in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 45 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php

When trying to enter admin/structure/types/manage/article/fields/add-field

Or if this would be another/new issue.

Raised this in slack with @catch, posting response below:

I still think #20 is what we should do tbh. Use the assertion to find the errors, fix the errors in their own issue, then add the assertion to core itself later.

Back to NW to get this into an MR.