\Drupal\user\ContextProvider\CurrentUserContext::onBlockActiveContext() loads the anonymous user

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

This one is unfortunately still valid, the code has barely changed.

#28 might have been a red herring all that time ago, or have become one - while constructing an entity still gets field definitions, so does accessing any field.

I tested with Umami, with the 'disclaimer' block visibility set to anonymous users, and with page cache uninstalled, and after truncating dynamic_page_cache (could have uninstalled dynamic_page_cache_instead).

Drupal\block_content\Entity\BlockContent::isReusable() and Drupal\user\Entity\User::getRoles() both call Entity::get(). It's pretty likely that the current user context being in use means that at least one field will be accessed, so we might as well save loading the entity.

Total function call difference in xhprof is -200 but I'm hoping we'll also see a cache get or some queries disappear in performance tests.

Performance tests show a clear improvement. This means #38 is wrong, could be one of two reasons:

1. We were already getting field definitions in other places ten years ago.

2. We're getting field definitions now that we weren't previously.

But given this is a clear improvement, I think we should go ahead with what we originally planned.

📌 Make EntityTypeManager provide an entity factory Needs work is still there to defer things even later.

Had to update CurrentUserContextTest to create the anonymous user in the database and fix assertions - it's testing for completely the wrong behaviour. The change here makes the test 'fail' but only because it's causing the anonymous user to be available whereas it was previously not found.

Wondering if we want a follow-up for #28 / #29 to avoid loading the user entity at all, whether that's worth attempting will depend on 📌 Load user entity in Cookie AuthenticationProvider instead of using manual queries Needs work .

Had another think about it and we might be able to do this as the follow-up: 📌 [12.x] Try to use property hooks to lazy instantiate entity keys Active .

Awesome to see these old issues get revived!