The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 5:06pm 16 August 2023 - last update
over 1 year ago Custom Commands Failed - ๐ซ๐ทFrance prudloff Lille
I tried to reroll the #49 patch for 9.5.9 but the field settings form was not working correctly: settings were not saved and AJAX requests did nothing.
I reworked the patch and now everything seems to work on my setup.
Unfortunately, I had to duplicate some methods fromEntityReferenceItem
.(I tried to generate an interdiff but it fails for some reason.)
- last update
over 1 year ago Custom Commands Failed - ๐ซ๐ทFrance prudloff Lille
#53 was causing errors with existing fields, it should be better now.
- Status changed to Needs work
over 1 year ago 2:28pm 20 August 2023 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 12:43pm 23 August 2023 - last update
over 1 year ago Build Successful - ๐ซ๐ทFrance prudloff Lille
Just noticed it triggers an exception in the widget when the target_type setting is empty.
I updated the patch to fix that. - Status changed to Needs work
over 1 year ago 1:08pm 23 August 2023 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 1:32pm 23 August 2023 - last update
over 1 year ago Build Successful - ๐ซ๐ทFrance prudloff Lille
LinkWidget
tries to callgetFieldSetting
statically and it can't work. - last update
over 1 year ago Build Successful - ๐ซ๐ทFrance prudloff Lille
Fixed a notice when handler_settings is NULL.
- Status changed to Needs work
over 1 year ago 5:41pm 26 August 2023 - ๐บ๐ธUnited States smustgrave
Was previously tagged for tests which I believe are still needed.
And with the schema change an upgrade path may be needed.
But also there seemed to be some failures.
- ๐ซ๐ทFrance prudloff Lille
#60 was using the new node handler by default instead of keeping the old behavior.
The new handler should be opt-in. - last update
about 1 year ago Build Successful - ๐ซ๐ทFrance GaรซlG Lille, France
gaรซlg โ made their first commit to this issueโs fork.