The cell.active_table_sort in table.html.twig has no effect

Created on 27 October 2014, over 10 years ago

Updated 20 April 2024, 12 months ago

While reviewing #1821454: [theme_table] 'active' class added to wrong column → , I detected that the twig variable cell.active_table_sort used in table.html.twig is affected by a combination of defects:

The active class is set by tablesort_header().
The cell.active_table_sort twig variable is never set for header cells. However, in the twig template it is only ever checked when processing the header section (for cell in header).
In contrast the cell.active_table_sort is set for cells in rows and footer, but in the twig template it is never checked when processing rows or footer section

Either remove cell.active_table_sort or fix it.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Theme →

Last updated about 24 hours ago

Created by

🇨🇭Switzerland znerol

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 12 months ago →
🇳🇿New Zealand quietone
There has been activity here for 8 years. So, is this problem still relevant?

Since we need more information to move forward with this issue, I am setting the status to Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!
Status changed to Postponed: needs info 12 months ago10:40am 20 April 2024
Comment 12 months ago →
🇳🇿New Zealand quietone
Comment 2 months ago →
🇳🇿New Zealand luke.stewart
luke.stewart → made their first commit to this issue’s fork.
Comment 2 months ago →
🇳🇿New Zealand luke.stewart
In the intervening time we have different themes.

I've rerolled/adapted the previous patch and lets see what testing says.

Production build 0.71.5 2024