Contrib.social

Add a Settings storage object

Open on Drupal.org →
Created on 29 August 2014, about 11 years ago
Updated 29 August 2025, 1 day ago

While reviewing #2256257-11: Move token seed in SessionManager in isSessionObsolete() and regenerate() to the MetadataBag → I saw this ugly messing of object mocking for an object that clearly didn't need it. While investigating I found it was because of the complicated way we've set up our Settings object.

In this patch we separate the settings storage from the Settings class and create a separate class to handle it. The storage class can then be instantiated on its own and injected into a constructor during testing.

This retains all the read-only aspects of the settings system. The container won't allow it to be over-ridden and the static methods on Settings will behave in the exact same manner and retain the same interface.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

base system

Created by

🇺🇸United States neclimdul Houston, TX

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 1 day ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024