Duplicate titleRow variable and convert to $titleRow since it is a jQuery object

Created on 13 July 2014, about 10 years ago
Updated 9 April 2023, over 1 year ago

Problem/Motivation

The titleRow variable is unused/duplicate and also does not conform to the new standards of prefixing a JS variable with $ if it is a jQuery object.

Proposed resolution

Remove duplicate and refactor all usages to be $titleRow.
Patch below.

Remaining tasks

None.

User interface changes

None.

API changes

None.

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
Views UIΒ  β†’

Last updated 9 days ago

Created by

πŸ‡ΊπŸ‡ΈUnited States Elijah Lynn Portland, Oregon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Rerolled for D10

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave
  • Status changed to Needs work over 1 year ago
  • πŸ‡³πŸ‡±Netherlands Lendude Amsterdam

    If we care about this, shouldn't there be a linting rule made for this? Or is it not possible to track these down? Or should we use this to try and move away from jQuery and not changing the variable name and changing the use of jQuery to vanilla-js per 🌱 [meta] Replace JQuery with vanilla Javascript in core Active ?

    Anyway, there are more of these floating around this file. If we are changing this let's at least change all of them in this file and not just one or two variables

    Quick scan:

            titleRow = $('tr#views-group-title-2');
            newRow = $(
              '<tr class="filter-group-operator-row"><td colspan="5"></td></tr>',
            );
    
    const groupField = $(
                'select.views-group-select',
                this.rowObject.element,
              );

    const rows = $(this.table).find('tr');

    might be more....

Production build 0.71.5 2024