The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 10:04pm 8 April 2023 - Status changed to Needs work
over 1 year ago 6:20am 9 April 2023 - π³π±Netherlands Lendude Amsterdam
If we care about this, shouldn't there be a linting rule made for this? Or is it not possible to track these down? Or should we use this to try and move away from jQuery and not changing the variable name and changing the use of jQuery to vanilla-js per π± [meta] Replace JQuery with vanilla Javascript in core Active ?
Anyway, there are more of these floating around this file. If we are changing this let's at least change all of them in this file and not just one or two variables
Quick scan:
titleRow = $('tr#views-group-title-2'); newRow = $( '<tr class="filter-group-operator-row"><td colspan="5"></td></tr>', );
const groupField = $( 'select.views-group-select', this.rowObject.element, );
const rows = $(this.table).find('tr');
might be more....