Contrib.social

Avoid dynamically defining constraints

Open on Drupal.org →
Created on 2 June 2014, almost 11 years ago
Updated 12 May 2025, about 13 hours ago

Problems

  • Currently, field items dynamically add constraint in TypedData::getConstraints(). Those constraints will be missing when you ask the FieldDefinition about the constraints.
  • Field definitions deal with constraint definitions as array, but TypedData::getConstraints() returns constraint objects. That ends up being confusing when you can expect an array and when an object,

Proposed resolution

  • Remove TypedData::getConstraints() and move constraint object instantiation to the Metadata classes.
  • Make Data/FieldDefinition::getConstraints() the primary source for getting constraint definitions. That requires us to either have a static method on field items that allows to add constraints based on field settings, or get #2023465: Allow validation constraints to add in message replacements → done.

Related:

#2105797: Add CompositeConstraintBase so that constraints involving multiple fields, such as CommentNameConstraint, can be discovered →
#2116341: Apply defaults to definition objects →

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

typed data system

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 13 hours ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024