Remove completely irrelevant addition of "menu-item__link" class in tabledrag.js

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Patch #3, no longer applies as #18. I have re-rolled the patch. please review

We have css in tabledrag.css for menu-item__link, are we 100% sure it's not used.

We have css in tabledrag.css for menu-item__link, are we 100% sure it's not used.

.touchevents .draggable .menu-item__link {
  padding-top: var(--space-xs);
  padding-bottom: var(--space-xs);
}

This CSS is applied to mobile devices, as the `.touchevents` class is available their only. But it doesn't have any effects on the element. As the parent element have property `vertical-align: middle;`. There is no need to align element by padding. I have added a screen recording for reference.

Makes sense.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Unrelated failure. restoring status

#21 sounds good but if so shouldn't we also remove that CSS rule? Or at least open a follow-up.

I have opened up a follow up issue for same.
📌 Removed unused CSS from tabledrag.css file Closed: duplicate

#catch i have tested the comment #27 mentioned issue, ( https://www.drupal.org/project/drupal/issues/3355904 📌 Removed unused CSS from tabledrag.css file Closed: duplicate ).

Unused css removed after the MR,
for reference i am also adding the screenshot here.

before

after

Tested the comment #19

class removed from the element

before

after

If you review this change with core's default styling (Stark), it looks like removing this class results in the label and tabledrag handle not being aligned. This would be a regression seen by sites not using Claro.

Because the issue was filed 9 years ago, there's a high likelihood that some sites have CSS expecting this class to be there. At the very least, the Stable 9 theme would need logic that keeps this class present so it maintains the "stable promise"

However, the image above also indicates that this class is not irrelevant. We could not remove it + all corresponding CSS. Refactoring would be needed, not just removal. At that point, there's a risk of disrupting existing sites to provide a class with a slightly better name, so I'm not sure how much incentive there is to make this change vs the disruptions it might cause + adding the Stable9 layer.

(if there's a decision to go ahead with this, there are comments in the code referencing this class that were not part of the patch. If we're removing something, all artifacts of it should be removed)