SiteSettingsForm needs to include install.inc

Created on 21 May 2014, over 10 years ago
Updated 3 May 2023, over 1 year ago

Problem/Motivation

SiteSettingsForm calls functions like drupal_get_database_types() and drupal_install_config_directories(), which are defined in core/includes/install.inc, but that file is not included. It can get away with this on Drupal installation because it's called from install.core.inc, which does include install.inc, but when reusing the form class in another context (specifically, for the database credentials step of the upgrade form for migration) it fails. Attached patch includes install.inc in each method referencing functions defined there - alternatively, we could just include it at the file level...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Fixed

Version

10.1 ✨

Component
InstallΒ  β†’

Last updated 2 days ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States mikeryan Murphysboro, IL, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024