- 🇮🇹Italy mondrake 🇮🇹
Found an issue with InstallerTestBase while working on the mysqli driver, fixed.
- Status changed to RTBC
almost 2 years ago 7:38pm 21 January 2023 58:22 54:22 Running- last update
over 1 year ago 29,298 pass, 2 fail - last update
over 1 year ago 29,306 pass - last update
over 1 year ago 29,325 pass - last update
over 1 year ago 29,325 pass - last update
over 1 year ago 29,323 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,394 pass - Status changed to Needs work
over 1 year ago 12:06pm 4 May 2023 - 🇬🇧United Kingdom catch
I'm concerned about the number of low level changes we're having to make after making database drivers modules, it feels a bit like all the special casing we've had over the years for install profiles. Having said that the code here seems OK in itself. I think this should be a target for early in the 10.2.x cycle so it has time to bed in. We should resolve @quietone's recent comment though so marking needs work for that.
- last update
over 1 year ago 29,371 pass, 40 fail - last update
over 1 year ago 29,401 pass - 🇮🇹Italy mondrake 🇮🇹
I have tried @quietone suggestion, but removing the line tests still fail. Reverted and reset to RTBC. Deprecations now are for 10.2.x.
- last update
over 1 year ago 29,401 pass - last update
over 1 year ago 29,401 pass - last update
over 1 year ago 29,402 pass - last update
over 1 year ago 29,403 pass - last update
over 1 year ago 29,405 pass - last update
over 1 year ago 29,405 pass - last update
over 1 year ago 29,382 pass, 2 fail - last update
over 1 year ago 29,405 pass - Status changed to RTBC
over 1 year ago 6:17pm 10 May 2023 - last update
over 1 year ago 29,405 pass - last update
over 1 year ago 29,411 pass - last update
over 1 year ago 29,411 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,417 pass, 1 fail - last update
over 1 year ago 29,424 pass 43:21 39:53 Running- last update
over 1 year ago 29,422 pass, 2 fail - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,434 pass - last update
over 1 year ago 29,440 pass - last update
over 1 year ago 29,459 pass - last update
over 1 year ago 29,460 pass - last update
over 1 year ago 29,465 pass - Status changed to Needs review
over 1 year ago 9:55pm 12 June 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Left some comments on the MR, huge effort here folks 💪
- Status changed to Needs work
over 1 year ago 3:29pm 13 June 2023 - 🇮🇹Italy mondrake 🇮🇹
Thank for the review @larowlan! NW to go through the points.
- last update
over 1 year ago 29,445 pass, 2 fail - last update
over 1 year ago 29,468 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,465 pass, 2 fail - last update
over 1 year ago 29,465 pass, 1 fail - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 4:43pm 14 June 2023 - 🇮🇹Italy mondrake 🇮🇹
Removed code from Database::findDriverAutoloadDirectory to use the new API. It's OK had an impact on a test. Can I get a review of latest changes before continuing with the rest of the points.
- last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,471 pass - Status changed to RTBC
over 1 year ago 6:39am 15 June 2023 - 🇳🇱Netherlands daffie
All points of @larowlan have been addressed.
A couple of followups have been created.
Back to RTBC. - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I took this for a spin locally, and tested that I could install with drush
Was able to install with `drush si demo_umami` and the site looked good with a click about.I agree with @catch in #112 that its best to get this into 10.2.x early and let any issues shake out.
So in line with that, committed to 11.x - thanks all!
💃
- Status changed to Fixed
over 1 year ago 10:47pm 15 June 2023 -
larowlan →
committed 6c1e7b07 on 11.x
Issue #3256642 by mondrake, daffie, yogeshmpawar, alexpott, tmaiochi,...
-
larowlan →
committed 6c1e7b07 on 11.x
- 🇫🇷France andypost
I bet it's good parent 📌 [META] Improve the extension system (modules, profiles, themes) Active
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 9:03pm 27 August 2023 - 🇸🇰Slovakia poker10
It seems like this issue caused regression on Windows: 🐛 "core_version_requirement key must be present" on core modules on Windows Needs review