ProfileForm::actions() defines new delete element instead of altering it as it expects

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

See [CR TBC]'

Does this need a change record?

Change looks good. Even though it's a task wonder if we could add a simple test that if we use "delete" we get the trigger_error correctly.

Yep, good point, this also meant I discovered I hadn't set the error type, so that's done now. Test behaves properly on local so here goes nothing.

Oops, crafted the test patch badly, here's what it should have been.

The last submitted patch, 33: 2250377-33.patch, failed testing. View results →

The last submitted patch, 34: 2250377-34-failing-test-only.patch, failed testing. View results →

uploaded patch for 10.1.x.

The last submitted patch, 33: 2250377-33.patch, failed testing. View results →

So, @sun was right in #5 (of course they were). API resources make this a bit of a challenge.

For example in \Drupal\jsonapi\Routing\Routes::getIndividualRoutesForResourceType line 308 we have

$individual_remove_route->setRequirement('_entity_access', "entity.delete");

which sets the route permission for *any* delete operation on an entity.

So we're faced with a few options:

1. Put special cases into the API systems to cater for the "cancel" entity access value, or
2. Instead of deprecating the delete key for users, differentiate between them for API vs Forms, possibly with an additional permission, or
3. Leave well enough alone.

Honestly I'm inclined towards the third option.

Hiding patch from #37 as it regressed functionality, did not apply, has no interdiff, and did not come with any explanation of what it was trying to achieve.

Uploading patch again for 10.1.x after resolvng the errors of custom commands.

Per #39

Thank you for the interest @Ajeet Tiwari but it is expected to test a patch before uploading so have to remove credit for that.

Just FYI to help get the message out there.

Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines → for more information.

tried to fix the CCF error and to fix the error in #34.

Fixed CCF for #43.

Hiding #43 as there is no interdiff being provided. Also removing credit as it's expected patches to be tested before uploading. #43 appears to be adding additional changes also.

#44 carried forward those additional changes.

Please read #39 before continuing.

@darvanen would agree on option 3 also FWIW