Status: Incomplete — This is just a first proposal.
Since PHP 5.4, stream wrappers have matured significantly; our entire Drupal-specific StreamWrapperInterface is most likely obsolete.
(cf.
#2107287: PHP 5.4 calls a new stream_metadata() method on stream wrappers not implemented by Drupal →
)
Most of the functions used for file operations are split between file.inc and file.module. They can be grouped by purpose and consolidated as services inside of Drupal\Core\File namespace:
File API functions consuming Settings to ensure that created files are readable/writable:
drupal_chmod()
drupal_unlink()
drupal_mkdir()
drupal_rmdir()
Drupal\Core\File\FileHandler
— or similar; the Drupal-specific File API helper functions from
#2050759: Move drupal_chmod and other code in file.inc to a Drupal\Core\File\FileSystem class →
drupal_dirname()
drupal_basename()
drupal_tempnam()
drupal_move_uploaded_file()
file_upload_max_size()
file_directory_os_temp()
file_create_filename()
file_unmanaged_copy()
file_unmanaged_prepare()
file_unmanaged_move()
file_unmanaged_delete()
file_unmanaged_delete_recursive()
file_unmanaged_save_data()
They are transformed by #2244513: Move the unmanaged file APIs to the file_system service (file.inc) → into this interface:
namespace Drupal\Core\File\Handler;
interface UnmanagedFileHandlerInterface extends FileHandlerInterface {
public function copy($source, $destination = NULL, $replace = self::FILE_EXISTS_RENAME);
public function delete($path);
public function deleteRecursive($path, callable $callback = NULL);
public function move($source, $destination = NULL, $replace = self::FILE_EXISTS_RENAME);
public function prepare($source, &$destination = NULL, $replace = self::FILE_EXISTS_RENAME) {
public function saveData($data, $destination = NULL, $replace = self::FILE_EXISTS_RENAME);
}
file_ensure_htaccess()
file_htaccess_lines()
file_save_htaccess()
Transformed by #2620304: htaccess functions should be a service → into
namespace Drupal\Core\File;
class Htaccess {
public function ensure() {
}
public function save($directory, $private = TRUE, $force_overwrite = FALSE) {
}
}
file_create_url()
file_url_transform_relative()
Transformed by #2669074: Convert file_create_url() & file_url_transform_relative() to service, deprecate it → into
namespace Drupal\Core\File;
class FileUrlGenerator {
public function generate($uri, $relative = FALSE) {
}
public function transformRelative($file_url) {
}
}
file_scan_directory()
file_get_mimetype()
For stream wrappers, we should arrive at this for D8:
Drupal\Component\StreamWrapper\StreamWrapperInterface [ex. PhpStreamWrapperInterface]
Drupal\Component\StreamWrapper\StreamWrapperManager
Drupal\Component\StreamWrapper\LocalStreamBase [sans getLabel()/getDescription()]
...
Drupal\Core\StreamWrapper\StreamWrapperInterface [extends Component\StreamWrapperInterface, adding getLabel()/getDescription()]
Drupal\Core\StreamWrapper\PublicStream
Drupal\Core\StreamWrapper\TemporaryStream
Drupal\Core\StreamWrapper\PrivateStream
→ Our StreamWrapper mechanism turns into a re-usable component.
settings.php file and (local) stream wrapper settings should turn into this:
$settings['file_chmod_directory'] = ...;
$settings['file_chmod_file'] = ...;
$settings['stream']['public'] = ...;
$settings['stream']['private'] = ...;
$settings['stream']['temporary'] = ...;
Active
10.1 ✨
Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
From SteamWrapperInterface.php:
* Note that PHP 5.2 fopen() only supports URIs of the form "scheme://target"
* despite the fact that according to RFC 3986 a URI's scheme component
* delimiter is in general just ":", not "://". Because of this PHP limitation
* and for consistency Drupal will only accept URIs of form "scheme://target".
This is something that can be updated, as there's no need to support PHP 5.2 anymore.