ThemeNegotiatorInterface does not use the same methods as the ThemeNegotiator

Created on 12 January 2014, over 10 years ago

Updated 5 July 2023, about 1 year ago

Updated: Comment 0

Problem/Motivation

The public function on ThemeNegotiator determineActiveTheme is on the interface, but actually getActiveTheme is the wrong that implements the "cacheing" logic.

Proposed resolution

Maybe switch getActiveTheme to the interface

Remaining tasks

User interface changes

API changes

🐛 Bug report

Status

Closed: outdated

Version

9.5

Component

Theme →

Last updated 1 day ago

Maintained by
🇺🇸United States @effulgentsia
🇩🇪Germany @Fabianx
🇨🇦Canada @joelpittet
🇫🇮Finland @lauriii

Created by

🇩🇪Germany dawehner

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇺🇸United States smustgrave
Since there has not been a follow up for #14

If still a valid bug please reopen updating issue summary addressing #14

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024