- π«π·France Chris64 France
Here some thing for 2.x-dev in a short way. Is complementary to search on specific columns.
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 8:29pm 10 November 2023 - π«π·France Chris64 France
@Anybody, these old patches are outdated. Patch #2 β¨ Exclude columns from searching Needs work purpose is more general than column search property. The patches here enable search to several columns and not only one as asked in the issue. Such a feature is needed since only one search box might be used and some columns should not be used for search.
bSearchable
column property is right for this. Each datatable need its own configuration. Better than an hook.
+ 'thead_unsearchable' => $this->t('Table Column: Unsearchable'),
To enable to tell explicitly the column is unsearchable.bSearchable
value is a booleanTRUE|FALSE
.
+ $column_options['bSearchable'] = 'thead_unsearchable' !== ($options['filter_columns'][$field] ?? '');
provide a boolean value onlyFALSE
if$options['filter_columns'][$field]
is set to'thead_unsearchable'
, as required. - Status changed to Needs review
12 months ago 9:31pm 16 November 2023 - Status changed to Needs work
12 months ago 11:22am 20 November 2023 - π©πͺGermany Anybody Porta Westfalica
@Chris64 could we have this as MR also?
That's always the better modern alternative to patches.
- Merge request !16With comments: datatables-bsearchable-2114991-8.patch β (Merged) created by Chris64
- Status changed to Needs review
12 months ago 8:44pm 21 November 2023 - Status changed to RTBC
12 months ago 7:57am 22 November 2023 - π©πͺGermany Anybody Porta Westfalica
Thanks, the MR LGTM! Still it would be super helpful to have tests for all of this, so we could be sure it works as expected.
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
diqidoq β made their first commit to this issueβs fork.
-
diqidoq β
committed b67f8fba on 2.x authored by
Chris64 β
Issue #2114991 by Chris64, Elin Yordanov, Anybody: Exclude columns from...
-
diqidoq β
committed b67f8fba on 2.x authored by
Chris64 β
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
Let's have some courage to get on with the next release. *hides* I hope I will not complani about this later ;-)
- Status changed to Fixed
10 months ago 5:39pm 17 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.