Add linkByHrefExistsExact and linkByHrefNotExistsExact for matching links by href exactly

I just encountered this in https://git.drupalcode.org/project/drupal/-/merge_requests/4777/diffs

IMO we should copy what we do with the label equivalents and do linkByHrefExistsExact and linkByHrefNotExistsExact

I can't imagine changing the existing functions will be met well in contrib/custom project land.

Let's see what people think, will re-title the issue once there is buy in.

Agree with @acbramley, if we change the existing functions will have to be very careful. But adding 2 new seems like a good idea.

Tagging for a simple change record to announce them.

Updated one test in core to use the new functions and updated title/IS

https://www.drupal.org/node/3387433 → CR added

CR reads well. Short and sweet.

Seems to o have a test failure though

Reverted the test changes, as per #31 they are in a subdirectory. Can't exactly remember how to print that reliably.

LGTM!

Committed 48b8518 and pushed to 11.x. Thanks!

Backported to 10.1.x because I think we'll need this for bugfixes

Changing the category to task.

Published the CR

This would have needed tests in WebAssertTest.

Reverted for #47 - thanks @mondrake

linkByHrefExists/linkByHrefNotExists don't have test coverage in there, so I'll add that while I'm at it.

Since we're hardcoding URLs in markup in these test pages I didn't need to bother with base_path handling :)

LGTM!

spotted an issue with one of the tests, verified it locally by putting $this->fail() between the two asserts and it still passed

Feedback appears to have been addressed.

Can we refactor what went in in 🐛 Generic Revision UI's Revision overview page generates wrong operations/view links for a translation Fixed to use the new methods

Thanks!

It seem to me that this should be committed and then the people working on that issue should update their tests to use it.

That was the plan but the other issue went in first inadvertently

Actioned #58

Think this one is ready to go

Committed to 11.x

Technically this is a tasks so we normally wouldn't backport, however it is test-only code and will make fixing bugs simpler.

So I've backported to 10.1.x for consistency.

Automatically closed - issue fixed for 2 weeks with no activity.

acbramley → closed merge request !4779