- First commit to issue fork.
- Merge request !7549Issue #1956016: user_filters() shows permission machine names rather than human labels, and tries to translate them → (Open) created by apaderno
- last update
8 months ago 2,179 pass - Status changed to Needs review
8 months ago 4:09pm 17 April 2024 - last update
8 months ago Patch Failed to Apply - 🇦🇺Australia klonos 90% Melbourne, Australia - 10% Larissa, Greece
The module strings (used for the groupings in the select menu) are also their machine names, while they should be the human-readable names.
I've updated the issue summary and description accordingly.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I added a link to the documentation page for
user_filters(). - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Waiting for branch to pass - 🇮🇹Italy apaderno Brescia, 🇮🇹
There is a failing test, but it does not seem caused by the changes introduced in this MR.
Status Group Filename Line Function -------------------------------------------------------------------------------- Fail Other bootstrap.test 197 BootstrapPageCacheTestCase->testPag X-Content-Type-Options header was sent.
- 🇸🇰Slovakia poker10
The failure is caused by changes from this issue: 🐛 Duplicate X-Content-Type-Options headers both with the value nosniff [D7] Fixed . The MR needs to be rebased and then it should be green again.
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Status changed to Needs work
23 days ago 5:04pm 29 November 2024 - 🇸🇰Slovakia poker10
Thanks for working on this. I think this is a usefull fix, as currently only machine readable names of modules and permissions are displayed.
I have added some minor comments to the MR. Moving to NW for them.
Tests are green: https://git.drupalcode.org/issue/drupal-1956016/-/pipelines/207490 , but I do not think this filter is tested anywhere right now, so probably manual testing will be needed, or a simple test.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I apologize: I saw the comments on the merge request, but I was not able to find this issue when I was ready to change the merge request.