Benchmark: Bypass magic to speed up the new entity field API

Created on 29 August 2012, almost 13 years ago

Updated 19 May 2025, about 1 month ago

I figured out it's possible to write to $this->$name without issuing a __set() call from inside __set(). This allows for a "magic-magic-static-cache". I've run some quick benchmark:

With my branch:

17009.16ms for 1000000 runs. 
0.01700916ms per run

With the attached patch applied:

12672.81ms for 1000000 runs. 
0.01267281ms per run

So the property access improve from 17µs to 12,67µs on my machine. I'd have expected the difference to be bigger though. :/

Benchmarked code:

 $iterations = 1000000;

timer_start('test');
for ($i = 0; $i < $iterations; $i++) {
	    $entity->user_id->value = 1; 
 }
timer_stop('test');
echo timer_read('test')."ms for $iterations runs. \n";
echo (timer_read('test') / $iterations) ."ms per run";

📌 Task

Status

Postponed: needs info

Version

11.0 🔥

Component

entity system

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.

Performance
It affects performance. It is often combined with the Needs profiling tag.

needs profiling
It may affect performance, and thus requires in-depth technical reviews and profiling.

Entity Field API

Needs benchmarks

stale-issue-cleanup
To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 month ago →
🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024