- 🇳🇱Netherlands EsfoNL
small compatibility fix for Drupal 10
undefined call to file_move - 🇳🇱Netherlands EsfoNL
fix stupid issue with previous patch where i passed the plain file object to move instead of calling getFileUri on it.
- 🇳🇱Netherlands Johan den Hollander
The #45 patch is a small step forward but some odd things:
When creating a new Media entity with this patch enabled:
First add file, then select private storage.
-Upload a file
-Select Private storage
-Save entity
-Edit media entity again.
-Notice it has been stored as a public file.First select storage, then upload a file.
-Set storage to private.
-Upload a file
-Notice that private has been reset to public, set to private again
-Save entity
-Edit media entity again.
-Notice is has the correct setting, private storage.Now when you want to change the file from private to public it is not possible anymore. It will always be private.
- last update
almost 2 years ago Patch Failed to Apply - last update
almost 2 years ago Patch Failed to Apply - Status changed to Needs review
almost 2 years ago 8:53am 15 November 2023 - last update
almost 2 years ago Custom Commands Failed - Status changed to Needs work
almost 2 years ago 9:05am 15 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
almost 2 years ago 9:09am 15 November 2023 - Status changed to Needs work
almost 2 years ago 3:37pm 15 November 2023 - 🇺🇸United States smustgrave
Please include interdiffs with all patches.
Issue summary could use some updating.
- 🇳🇱Netherlands Johan den Hollander
Updated the patch to be compatible with the latest 10.5.x release.
Main differences:
1. Updated imports in FileWidget.php to match Drupal 10.5.x structure
2. Fixed import ordering to be compatible with current codebasecore/modules/file/src/Plugin/Field/FieldWidget/FileWidget.php:
- Added missing import for StreamWrapperInterface (line 14)
- Added missing import for FileInterface (line 19)
- Adjusted import ordering to match Drupal 10.5.x conventions
- Added use statement for Drupal\Core\Url which was missing in patch #49Technical details:
------------------
The original patch #49 failed to apply to Drupal 10.5.x because:
1. The import structure in FileWidget.php changed between versions
2. Additional imports (like Drupal\Core\Url) were added to 10.5.x
3. The patch context didn't match the current file structureThese changes make the patch compatible with Drupal 10.5.x while
maintaining all the original functionality for the uri_scheme_field feature.All other functionality remains identical to patch #49.