Set fixed "from:" and add "Reply-to:" to comply with DMARC

HI,

Am I missing something? I've applied patch #232 but I am not seeing the 'Reply-To' headers in emails coming from the contact form.

Thanks,
Eric

I found the issue but I'm not sure how to fix it...

The email headers it generates are 'incorrect', for example

To: webmaster@ipmsusa.org, eric.aitala@gmail.com
Subject: [Website feedback] Another test
X-PHP-Script: reviews.ipmsusa.org/index.php for 71.58.100.178
 X-PHP-Originating-Script: 1001:PhpMail.php
MIME-Version: 1.0
 Content-Type: text/html
 Content-Transfer-Encoding: 8Bit
 X-Mailer: Drupal
 Sender: webmaster@ipmsusa.org
 From: IPMS/USA Reviews <webmaster@ipmsusa.org>
 Reply-to: ema13@psu.edu
Message-Id: <E1pXTxb-0000tI-Jz@server.ipmsusa3.org>
From: webmaster@ipmsusa.org
Date: Wed, 01 Mar 2023 16:26:03 -0500

Eric (not verified) (ema13@psu.edu) sent a message using the contact form at
https://reviews.ipmsusa.org/contact.

Note that after the 'MIME-Version' line, the following six lines begin with a space. That _appears_ to be enough to cause issues. I think.

I used the Header tester at: https://mxtoolbox.com/Public/Tools/EmailHeaders.aspx and it did not find the 'Reply-To' field unless I removed the leading space... I'm just not sure how to fix it in the patch.

Thanks,
Eric

@aitala feels like an old bug.

https://bugs.php.net/bug.php?id=73507

@pandaski I have turned off mail.add_x_header in the php.ini and settings.php and that had no effect.

This is with PHP8.1 but when I switch it back to PHP7.4, things seem to work... (I just noticed this...)

Eric

@aitala:

Note that after the 'MIME-Version' line, the following six lines begin with a space. That _appears_ to be enough to cause issues. I think.

You've correctly identified the cause of the problem. That happens because of the line-endings issue in Drupal/PHP/Mail.

The RFC says that all line must end with \r\n.
Earlier versons of PHP and some earlier versions of some mail servers don't respect the RFC.
That hasn't been true for many years now, yet Drupal core and many mail servers still try to force line endings to be wrong in order to accommodate broken implementations.

IMO Drupal should be strictly adhering to the RFC. All headers and all line MUST end with \r\n. Using a different line ending always causes problems, and at this point in history we should reject the incorrectly-formatted emails that use only \n as line endings.

Hello everyone!

Can someone please look into this?

I am not able to contact the module maintainers to help with review/merge of MRs :(

Note that drupal.org itself is affected by this issue.

Issue has been RTBC since October 2022. Is there anything else that needs to be done or that we can help with?

Since this is a backport, I wanted to check if there were any changes in modern Drupal to be aware of.

D8 commit: https://git.drupalcode.org/project/drupal/-/commit/8e92d3b
Current implementation: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

The approach for D7 is different, the API explicitly accepts a reply-to instead of from address. So that does not apply for the current approach here since it is rewriting the from email address.

And I rebased the MR for GitLab CI testing.