skinr-ui uses a three-parameter concat function:
$result = db_select('block', 'b')
->fields('b')
->distinct()
->where('CONCAT(b.module, \'-\', b.delta) = :identifier', array(':identifier' => $form['skinr']['sid']['#value']))
->range(0, 1)
->execute();
Now, it would be possible to hop on over to the skinr queue and ask them to split the form value and do a two-clause where instead; however, as a postgres user, this seems sort of like an uphill battle. Unless Drupal is going to forbid three-parameter CONCAT functions (and how would that policy be communicated?), it seems better to support this in core so that we don't have to keep chasing these down whenever they pop up.
The attached patch defines an update function and modifies the pgsql install function to define a new three-argument CONCAT function. Using anynonarray for all three parameters rather than trying to hit all permutations of text and anynonarray seems preferable, and works in the current instance.
To reproduce: On a Drupal-7 install using postgres, install and enable skinr and skinr-ui with some theme that uses it (fusion-starter is good). Mouse over the "configure" widget and select "edit skin". Without this patch, you get the following error:
PDOException: SQLSTATE[42883]: Undefined function: 7 ERROR: function concat(character varying, unknown, character varying) does not exist LINE 4: WHERE (CONCAT(b.module, '-', b.delta) = 'search-form') ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts.: SELECT DISTINCT b.* FROM {block} b WHERE (CONCAT(b.module, '-', b.delta) = :identifier) LIMIT 1 OFFSET 0; Array ( [:identifier] => search-form ) in block_skinr_preprocess_hook_callback() (line 94 of /srv/www/d7.com/sites/all/modules/skinr/modules/block.skinr.inc).
Apply this patch and run updatedb, and the above operation works fine (edit skin dialog is displayed).
Waiting for this patch to land? Change your working directory to your site's configuration folder (containing settings.php) and run the following drush command:
drush sqlq "CREATE OR REPLACE FUNCTION \"concat\"(anynonarray, anynonarray, anynonarray) RETURNS text AS 'SELECT CAST(\$1 AS text) || CAST(\$2 AS text) || CAST(\$3 AS text);' LANGUAGE 'sql';"
This has the same affect as the attached patch, but of course is temporary in nature (must be done once per d7 site). Workaround does not cause problems with the update script in this patch.
Postponed: needs info
11.0 🔥
database system
Particularly affects sites running on the PostgreSQL database.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
So question is if this is still relevant? #9 asked for a IS update in 2016 which hasn't happened. Say if no follow up we close in 3 months.
Yes, waiting 9 years is a strong indication that this is not needed. db-query was removed from core before the latest patch here. Plus, we have an active database maintainer that hasn't commented. So, I think this can be closed. If anyone disagrees, re-open and explain in a comment. Thanks.