cedric_a → created an issue.
Here is another proposal as someone told me that the first one is representing an external link... so maybe you'll like this one more...
If you use this one, don't forget to rename the file logo.png
Here is a logo proposal...
Just a precision on @gwenweb comment (we discussed the patch together at DC Lille) she mean that we need someone to review the code to ensure that only image styles using the updated focal point are flushed.
I just tested the patch #19 on a fresh Drupal 10.1.5 with Custom Search 8.x-1.0-beta9 and I could override the template custom-search-result.html.twig by copying it from the module folder to my custom theme folder.
However, the twig debug is showing this error message in the markup :
<!-- THEME DEBUG -->
<!-- THEME HOOK: 'search_result' -->
<!-- FILE NAME SUGGESTIONS:
* search-result--node-search.html.twig
* search-result.html.twig
-->
<!-- INVALID FILE NAME SUGGESTIONS:
See https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Render!theme.api.php/function/hook_theme_suggestions_alter
custom_search_result__node_search
custom_search_result
-->
<!-- BEGIN OUTPUT from 'themes/thematik/templates/custom-search-result.html.twig' -->
[...]
<!-- END OUTPUT from 'themes/thematik/templates/custom-search-result.html.twig' -->
So I looked at the api doc mentionned and spoted this :
New suggestions must begin with the value of HOOK, followed by two underscores to be discoverable.
I tested to change the suggestions from "custom_search_result__" to "search_result__", it removes the warning and show the template used with an "x".
But I think that it's not the suggestion name that we want because it is the name of the core search result template.
Should we adopt a suggestion name like "search_result__custom_search__" ?
I'm wondering if these changes will break backward compatibility too.
Thank you @sandboxpl for your work on this module and your reactivity on this issue !
I think that replacing the once library is not suffisient, we should also change the use of the once() function in the JS code. I took example in this issue https://www.drupal.org/project/drupal/issues/3183149 →
I updated merge request !10. It includes code changes from the bot in #2 + changes from reenaraghavan in #10 + my changes according to what I just said.
cedric_a → made their first commit to this issue’s fork.
Applying the right status according to #4 and regarding the content of the patch
This patch is looking fine ^^