- First commit to issue fork.
- 🇫🇷France cedric_a France
I think that replacing the once library is not suffisient, we should also change the use of the once() function in the JS code. I took example in this issue https://www.drupal.org/project/drupal/issues/3183149 →
I updated merge request !10. It includes code changes from the bot in #2 + changes from reenaraghavan in #10 + my changes according to what I just said.
- Status changed to Needs review
almost 2 years ago 8:40pm 28 January 2023 - First commit to issue fork.
- 🇵🇱Poland sandboxpl Poland 🇵🇱
gilab asked for rebase ( 1 commit with updated tests ) , so I did so, let's just confirms if tests will pass
I've also triggered a test against core 10.x to see if we don't miss anything here - 🇵🇱Poland sandboxpl Poland 🇵🇱
Okey pretty much done after cleaning up some last leftovers in tests,
I'm just confused why D9,5 test switched from "pass" into "Build successful" , all tests are passing nicely, but something strange happens in the test run itself... - Status changed to RTBC
almost 2 years ago 9:01am 31 January 2023 - 🇵🇱Poland sandboxpl Poland 🇵🇱
Okey so the test against D9.5 was fine, but there was some integrity check failing on drupalci part of the job,
as expected, the problem resolved itself overnight, looks like we're good to go now -
sandboxpl →
committed f2978740 on 8.x-1.x authored by
cedric_a →
refactor(drupal 10): replaces use of jquery.once with core once library...
-
sandboxpl →
committed f2978740 on 8.x-1.x authored by
cedric_a →
-
sandboxpl →
committed 00e4aa35 on 8.x-1.x authored by
cedric_a →
feat(drupal 10): adds Drupal 10 compatibility in .info files Refs issue...
-
sandboxpl →
committed 00e4aa35 on 8.x-1.x authored by
cedric_a →
- 🇵🇱Poland sandboxpl Poland 🇵🇱
All right, I've merged the code and published new release, so drupal packagist can pick up d10 support. For the testing, I've enabled tests for D9.5 and D10 so we can keep an eye on both supported core version. Thanks everyone for pushing this one through!
- Status changed to Fixed
almost 2 years ago 12:44pm 31 January 2023 - 🇫🇷France cedric_a France
Thank you @sandboxpl for your work on this module and your reactivity on this issue !
Automatically closed - issue fixed for 2 weeks with no activity.