🇮🇹Italy @MXT

This does not work anymore in D10 version.

After adding % symbol, the widget keeps it, but then if you save the whole page display settings, the % is removed from value.

@athyamvidyasagar there is already a working patch (see #87 📌 Olivero: Center align content (instead of left align) Needs work ) that is much more advanced and takes into account many other aspects than yours, which is too simple.

Please before posting a patch be sure to read the whole thread and check the work already done by others first, thank you (this is the second time 📌 Olivero: Center align content (instead of left align) Needs work I say this in this thread)

In case you (or someone else) want to contribute to the conclusion of this work, what is missing to do is written in comment #88 📌 Olivero: Center align content (instead of left align) Needs work

Thank you.

For those wishing to test the above implementation, the related patch can be created by clicking on plain diff in the "Issue fork" box at the beginning of this thread.

I reproduce the current link here for convenience:

Plain diff to be applied as a patch

AAAHHH!!! Thank you very much @ressa!!!

So with my:

Probably, as often happens, it may be that the failure of the backend test is due to something really trivial, but which I haven't been able to see yet...

I was absolutely right! ;-D

And yes: this is the demonstration that with the right tools, the goal can be reached sooner and better: I didn't know about this Lando + Drupal Contributions: I absolutely have to find the time to try it.

Thank you for the tip @ressa, much appreciated!

Guys, this is getting absurd: I spent more time trying to fix the failing test than implementing the new feature that allows Olivero to be centered.

The beauty is that the test that fails on the backend, has nothing to do with the frontend functionality that works great, as confirmed by others above, so much so that we are using it successfully on an upcoming site (can't share the demo as it is not yet officially public).

The most absurd thing is that the element that the test is looking for exists because moveToElement does not fail, while the waitFor ElementPresent/Visible in the next line continues to fail. So, first it finds it and then it doesn't find it anymore?

Anyway I don't want to insist on this anymore, first to avoid spamming this thread with various attempts to fix the test, due to the fact that I'm basically working "blind", as the Nightwatch tests don't produce screenshots so that I can visually see where the problem is, and don't even run correctly on DrupalPod (I run them using $ddev nightwatch --tag olivero, but it doesn't work correctly: do you know a better way?). I tried to use DrupalPod because I still couldn't get Nightwatch to run correctly in my usual "docker4drupal" based local environment...

Probably, as often happens, it may be that the failure of the backend test is due to something really trivial, but which I haven't been able to see yet...

At this point I'm asking you all, and in particular Olivero's maintainer, for a suggestion on how best to proceed in this situation.

Thank you.

Thank you @Bhanu951,

I used DrupalPod → , and at the end I was able to create a new working branch based on 10.1.x in the (old) pre-existing issue fork following your suggestions.

In particular, using DrupalPod, I had to:

1. Start a DrupalPod session WITHOUT selecting an existing branch (so 10.1.x was automatically chosen)
2. Remove existing remote
3. Add new drupal-123456 remote
4. Create 123456-issue-short-description-10.1.x branch
5. Make/commit changes
6. Push the new branch
7. The new 123456-issue-short-description-10.1.x branch is now listed under the issue fork branches in the issue itself

Thank you.

Encountered the same issue trying to work on #3156754

I reread this tons of times:

I recommend branching in your local checkout and pushing from there. That way you can update 10.1.x from the canonical drupal project, which you can keep at the origin Git remote. Then branch from there and push to the issue fork’s Git remote.

but I just don't understand what I should do, sorry...

Can you please write down a crystal clear step by step guide for dummies where nothing is given for granted?

I really would like to contribute to Drupal...

(I also think that this should be "officially" documented somewhere, in the issue forks guide maybe? Or, better, it would be nice to have a feature somewhere that easily allows to fetch updates from the issue fork itself)