crzdev → credited sylvain lavielle → .
As mentionned by @crzdev in #4, having "font size" settings in generic "links" would be indeed strange. Though, having "Font family" in "Page header / Header Top Links" and Page header / Header Top Links" settings but not in "Page footer / Footer Links" and "Page footer / Footer Top Links" settings is kind of weird.
I already use the "hook_artisan_customizations_alter" to fix this, so there is no real issue here. If you consider the "Artisan - Customizations" form must contain only basic and most useful settings, that looks good to me. Despite, Let us know if you want to fix the "Font family" issue.
I noticed a little typo too in code to be fixed up : "numberic" -> "numeric". The typo was there before but I propagated it in the MR code, Sorry. I ll fix this shortly.
sylvain lavielle → changed the visibility of the branch 3497974-accent-border-color to active.
sylvain lavielle → changed the visibility of the branch 3497974-accent-border-color to hidden.
sylvain lavielle → created an issue.
sylvain lavielle → created an issue.
I had the same problem described in #17.
It looks to me the last reliable patch is the #9 one.
The #10 point is to be fixed too. I had an exception syncing files that is related to this point :
[error] TypeError: Drupal\content_sync\Normalizer\FileEntityNormalizer::denormalize(): Return value must be of type ArrayObject|array|string|int|float|bool|null, Drupal\file\Entity\File returned in Drupal\content_sync\Normalizer\FileEntityNormalizer->denormalize() (line 141 of /var/www/public/modules/contrib/content_sync/src/Normalizer/FileEntityNormalizer.php) #0 /var/www/vendor/symfony/serializer/Serializer.php(227): Drupal\content_sync\Normalizer\FileEntityNormalizer->denormalize()
> #1 /var/www/public/modules/contrib/content_sync/src/Importer/ContentImporter.php(64): Symfony\Component\Serializer\Serializer->denormalize()
> #2 /var/www/public/modules/contrib/content_sync/src/Form/ContentImportTrait.php(62): Drupal\content_sync\Importer\ContentImporter->importEntity()
> #3 /var/www/vendor/drush/drush/includes/batch.inc(256): Drupal\content_sync\Commands\ContentSyncCommands->syncContent()
> #4 /var/www/vendor/drush/drush/includes/batch.inc(201): _drush_batch_worker()
> #5 /var/www/vendor/drush/drush/includes/batch.inc(95): _drush_batch_command()
> #6 /var/www/vendor/drush/drush/src/Drupal/Commands/core/BatchCommands.php(20): drush_batch_command()
> #7 [internal function]: Drush\Drupal\Commands\core\BatchCommands->process()
> #8 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(257): call_user_func_array()
> #9 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
> #10 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
> #11 /var/www/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(386): Consolidation\AnnotatedCommand\CommandProcessor->process()
> #12 /var/www/vendor/symfony/console/Command/Command.php(312): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
> #13 /var/www/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
> #14 /var/www/vendor/symfony/console/Application.php(314): Symfony\Component\Console\Application->doRunCommand()
> #15 /var/www/vendor/symfony/console/Application.php(168): Symfony\Component\Console\Application->doRun()
> #16 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(124): Symfony\Component\Console\Application->run()
> #17 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(51): Drush\Runtime\Runtime->doRun()
> #18 /var/www/vendor/drush/drush/drush.php(77): Drush\Runtime\Runtime->run()
> #19 /var/www/vendor/drush/drush/drush(4): require('...')
> #20 /var/www/vendor/bin/drush(120): include('...')
> #21 {main}.
The error stands in the ./src/Normalizer/FileEntityNormalizer.php class al L.74 where you have to add a return type this way in order to be working :
public function denormalize($data, $class, $format = NULL, array $serializer_context = array()): array|string|int|float|bool|\ArrayObject|\Drupal\file\Entity\File|NULL
... Or define return type as "mixed"
I guess weather a function return a so mixed and incredible bunch of types we should be entitled to use "mixed" as a return type (no, no, this isn't a sarcasm :) ) as suggested in #10
I tested the #2 patch, but have a strange behavior : When I insert an inline document, all looks great until I click the CKEditor "source" button to edit the HTML source. When I do it, the source does not shows up and a JS error located in CK editor is thrown on the JS console. Another related side effect shows up when I save the document. The modifications made inside the WYSIWYG field are not saved, (I think, it's because CKEditor is not able to generate the modified HTML as when I click on the "source" button).
If I chose to insert a "block" style alignment instead of the "inline" one. All works perfectly well as before.
Is there someone having the same problem ? any idea about the "whyness" :)