I'm closing is as a duplicate, as I shouldn't get credit from a MR that was not merged and was solved in another issue.
Thanks for your review @vbouchet!
I checked again on a clean install. Yes, it seems that MR15 solved my problem but introduces that another issue. Patch from 3342348 also solves this issue, sorry about the confusion. We should mark this as solved.
Also, I should clarify code from the patch in #3 and in MR15 is not the same.
The patch just reverted changes from commit 10620a91 and was supposed to be a temporary fix and the MR is my proposed solution.
Hi @vbouchet, these are two unrelated issues, as @robert-arias pointed 🐛 Fails show the form of adding block to a category PHP TypeError Fixed .
That was a fast merge! Thanks @Daniel.Moberly!
Thanks @vbouchet and @rckstr_rohan!
Adding a path in case somebody needs it before the MR gets merged.
alexahumada → created an issue.
Hi @smustgrave,
sorry i forgot about the new interdiff policy.
The new patch can't be applied to Drupal 10 becouse some changes in code in 10.0.x and 10.1.x branches, notably some css classes present in #71 patch have been removed. Also, notable difference in size is caused by Drupal 10 using PostCSS to transpile pcss files to css using yarn → , which require changes to new .pcss.css files.
I'll try to work on the remaining task we have in #77 and #85, but sadly this new patch only addresses Drupal 10 compatibility.
Thanks dench0! Closing 3351574 🐛 Dependency CAPTCHA v1.10 not compatible with Drupal 10 Fixed as fixed.
Solved in 3351654 📌 Create a new module version compatible with captcha 2.x. Fixed .
grimreaper, take a look at https://www.drupal.org/project/layout_builder_browser/issues/3351162 🐛 Undefined array key "" in Drupal\layout_builder_browser\Form\BlockForm Closed: duplicate , and try the patch I posted there, maybe it can solve your case temporarily until we find a better solution.
alexahumada → created an issue.
MR 5 has been merged already, we only need a new release.
Thanks benhamelin and dineshkumarbollu!
Maybe issue 3351162 is related to this.
That issue can't be reproduced on a fresh install, you need at least one extra language set to default (in my case ES set as default language and EN as secondary) and it's not caused by other installed modules.
Can't be reproduced on a fresh install, you need at least one extra language set to default (in my case ES set as default language and EN as secondary).
Quick patch reverting changes in 10620a91 in case somebody needs it before we find a better solution.
alexahumada → created an issue.
I'm so sorry, I misunderstood your message.
There's another issue when adding a new block to a block category using the Place Block button in Layout Builder Browser settings, but is not related to this one.
The issue is not related with jquery.once, it is caused by an undefined array key.
Logs info:
Warning: Undefined array key "" in Drupal\layout_builder_browser\Form\BlockForm->form() (line 101 /var/www/html/web/modules/contrib/layout_builder_browser/src/Form/BlockForm.php)
It's caused by commit https://git.drupalcode.org/project/layout_builder_browser/-/commit/10620... in src/Form/BlockForm.php, if we revert the changes in that file modal works as expected.
Updated patch for 10.1.x.
Added another set of required changes and made a MR including josip.rajkovic patch.
alexahumada → made their first commit to this issue’s fork.
alexahumada → made their first commit to this issue’s fork.